Page MenuHomePhabricator

[lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC)
ClosedPublic

Authored by JDevlieghere on Apr 29 2020, 11:22 AM.

Details

Summary

This implements Greg's suggestion from D78825 to include AutoHandleEvents and SpawnThread in CommandInterpreterRunOptions. This is in preparation for adding a new overload for RunCommandInterpreter: SBCommandInterpreterRunResults RunCommandInterpreter(SBCommandInterpreterRunOptions &options);.

Diff Detail

Event Timeline

JDevlieghere created this revision.Apr 29 2020, 11:22 AM

Add reproducer instrumentation.

clayborg accepted this revision.Apr 29 2020, 5:21 PM
This revision is now accepted and ready to land.Apr 29 2020, 5:21 PM
labath accepted this revision.Apr 30 2020, 1:06 AM
labath added inline comments.
lldb/source/API/SBDebugger.cpp
1189–1190

Maybe document somewhere that the arguments take precedence over what's present in SBCommandInterpreterRunOptions

clayborg added inline comments.Apr 30 2020, 12:18 PM
lldb/source/API/SBDebugger.cpp
1190

I agree this is a good idea to do in the header doc. Also might be worth marking this and other functions RunCommandInterpreter as deprecated and point them to the new way of doing things once that patch is in where everything is in SBCommandInterpreterRunOptions and SBCommandInterpreterRunResults

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2020, 1:27 PM