This is an archive of the discontinued LLVM Phabricator instance.

[WIP][FileCollector] Add doc comments
ClosedPublic

Authored by jkorous on Apr 27 2020, 1:04 PM.

Details

Summary

I would like to use FileCollector and figured out I might as well add things that weren't obvious to me as comments/names.

One thing that I still don't get is the function of OverlayRoot. It looks like it's exposing this prefix from VFSWriter but I am not sure why.

Diff Detail

Event Timeline

jkorous created this revision.Apr 27 2020, 1:04 PM
JDevlieghere added inline comments.Apr 27 2020, 1:52 PM
llvm/include/llvm/Support/FileCollector.h
22–40

for the RedirectingFileSystem

24

s/at some point/eventually/

97

I'm not a fan of this rename, for two reasons:

  • It is the root of where files are copied.
  • It is the root of the RedirectingFileSystem.
jkorous updated this revision to Diff 262981.May 8 2020, 5:09 PM

Addressed the comments.

jkorous marked 3 inline comments as done.May 8 2020, 5:10 PM
jkorous added inline comments.
llvm/include/llvm/Support/FileCollector.h
97

Reverted this part.

JDevlieghere accepted this revision.May 9 2020, 12:46 AM
This revision is now accepted and ready to land.May 9 2020, 12:46 AM
This revision was automatically updated to reflect the committed changes.