This is an archive of the discontinued LLVM Phabricator instance.

[VE] Update branch instructions
ClosedPublic

Authored by kaz7 on Apr 26 2020, 6:36 PM.

Details

Summary

Changing all mnemonic to match assembly instructions to simplify mnemonic
naming rules. This time update all branch instructions. This also change
to use %s10 register consitently.

Depends on D78887.

Diff Detail

Event Timeline

kaz7 created this revision.Apr 26 2020, 6:36 PM

LGTM. Again, only some minor remarks.

llvm/lib/Target/VE/VEInstrInfo.cpp
28

unrelated change

207

Formatting. Please put the addMBB on the next line to follow the style of the code.

255

same

llvm/lib/Target/VE/VEInstrInfo.td
1129

In the tests below %lr has turned into %s10 . I suppose you could replace the asm string bsic %s10 here with bsic %lr to prevent this (at least for this pattern).

kaz7 updated this revision to Diff 260239.Apr 27 2020, 1:30 AM

Modify code to follow Simon-san's suggestions.

kaz7 marked 4 inline comments as done.Apr 27 2020, 1:34 AM
kaz7 added inline comments.
llvm/lib/Target/VE/VEInstrInfo.cpp
28

Reverted it.

207

Clang format modified it as this. I reverted it. Thanks.

255

same

llvm/lib/Target/VE/VEInstrInfo.td
1129

I modified them to use %s10 register consistently. I'll write it in the summary later. Thank you for the suggestion.

kaz7 edited the summary of this revision. (Show Details)Apr 27 2020, 1:36 AM
simoll accepted this revision.Apr 27 2020, 5:10 AM

Thanks for clarifying the %s10 change. LGTM :)

This revision is now accepted and ready to land.Apr 27 2020, 5:10 AM
This revision was automatically updated to reflect the committed changes.