This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Remove unused bits after 67b2dbd5a33583. NFC
AbandonedPublic

Authored by sammccall on Apr 24 2020, 5:17 PM.

Details

Reviewers
kbobyrev
Summary

I think these are all safe to remove, but this doesn't build for me right now
(https://github.com/clangd/clangd/issues/351) so please verify...

Diff Detail

Event Timeline

sammccall created this revision.Apr 24 2020, 5:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2020, 5:18 PM
kbobyrev added inline comments.Apr 24 2020, 6:11 PM
clang-tools-extra/clangd/Features.inc.in
2

I don't know how much code will have with ifdefs in the Clangd itself, but I can think of several places, so I'm not sure whether removing this is really needed (since I'd most likely add this back in the next patch or two). However, I'm OK with doing that, things might change.

The cleanup which will be correct regardless is removing the last implicit remnants of CLANGD_ENABLE_REMOTE from Dexp:

  • Features.in include is no longer needed
  • CMake's directive to include the directory with Features.in is also no longer needed.
kbobyrev added inline comments.Apr 26 2020, 5:09 PM
clang-tools-extra/clangd/index/remote/server/Server.cpp
12

This can also be removed.

16

This can be removed.

17

This can be removed.

sammccall abandoned this revision.May 5 2020, 1:42 AM

Obsoleted by D79313
(Sorry for ignoring this!)