I think these are all safe to remove, but this doesn't build for me right now
(https://github.com/clangd/clangd/issues/351) so please verify...
Details
Details
- Reviewers
kbobyrev
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clangd/Features.inc.in | ||
---|---|---|
2 | I don't know how much code will have with ifdefs in the Clangd itself, but I can think of several places, so I'm not sure whether removing this is really needed (since I'd most likely add this back in the next patch or two). However, I'm OK with doing that, things might change. The cleanup which will be correct regardless is removing the last implicit remnants of CLANGD_ENABLE_REMOTE from Dexp:
|
I don't know how much code will have with ifdefs in the Clangd itself, but I can think of several places, so I'm not sure whether removing this is really needed (since I'd most likely add this back in the next patch or two). However, I'm OK with doing that, things might change.
The cleanup which will be correct regardless is removing the last implicit remnants of CLANGD_ENABLE_REMOTE from Dexp: