This is an archive of the discontinued LLVM Phabricator instance.

Differential D78725

[flang] Remove unused variable
ClosedPublic

Authored by tskeith on Apr 23 2020, 9:17 AM.

Details

Reviewers
sscalpone
jdoerfert
DavidTruby
Commits
rG4ced7a48e68a: [flang] Remove unused variable

Diff Detail

Event Timeline

tskeith created this revision.Apr 23 2020, 9:17 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptApr 23 2020, 9:17 AM
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
sscalpone accepted this revision.Apr 23 2020, 9:19 AM
This revision is now accepted and ready to land.Apr 23 2020, 9:19 AM
Closed by commit rG4ced7a48e68a: [flang] Remove unused variable (authored by tskeith). · Explain WhyApr 23 2020, 9:43 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B54418: Diff 259599!Apr 23 2020, 10:18 AM

Revision Contents

PathSize
flang/
lib/
Semantics/
2 lines

Diff 259611

flang/lib/Semantics/type.cpp

Show First 20 Lines • Show All 332 Lines • ▼ Show 20 Lines
const DeclTypeSpec *InstantiateHelper::InstantiateType(const Symbol &symbol) { const DeclTypeSpec *InstantiateHelper::InstantiateType(const Symbol &symbol) {
const DeclTypeSpec *type{symbol.GetType()}; const DeclTypeSpec *type{symbol.GetType()};
if (!type) { if (!type) {
return nullptr; // error has occurred return nullptr; // error has occurred
} else if (const DerivedTypeSpec * spec{type->AsDerived()}) { } else if (const DerivedTypeSpec * spec{type->AsDerived()}) {
return &FindOrInstantiateDerivedType(scope_, return &FindOrInstantiateDerivedType(scope_,
CreateDerivedTypeSpec(*spec, symbol.test(Symbol::Flag::ParentComp)), CreateDerivedTypeSpec(*spec, symbol.test(Symbol::Flag::ParentComp)),
context_, type->category()); context_, type->category());
} else if (const IntrinsicTypeSpec * intrinsic{type->AsIntrinsic()}) { } else if (type->AsIntrinsic()) {
return &InstantiateIntrinsicType(*type); return &InstantiateIntrinsicType(*type);
} else if (type->category() == DeclTypeSpec::ClassStar) { } else if (type->category() == DeclTypeSpec::ClassStar) {
return type; return type;
} else { } else {
common::die("InstantiateType: %s", type->AsFortran().c_str()); common::die("InstantiateType: %s", type->AsFortran().c_str());
} }
} }
▲ Show 20 Lines • Show All 339 Lines • Show Last 20 Lines