llvm: IPO: handle IRMover error handling, bug #45636

[trofi]

Summary

Missing error mangling is noticed in
https://bugs.llvm.org/show_bug.cgi?id=45636
where inconsistent profiling input caused
llvm/lld to crash as:

Program aborted due to an unhandled Error:
linking module flags 'ProfileSummary':
  IDs have conflicting values in 'Mutex_posix.o' and 'nsBrowserApp.o'

The change does not change the fact that LLVM crashes
but changes error output to say what was incorrect:

LLVM ERROR: Function Import: link error:
  linking module flags 'ProfileSummary':
    IDs have conflicting values in 'Mutex_posix.o' and 'nsBrowserApp.o'

Actual crash has yet to be fixed.

[lattner]

thanks!

[trofi]

Thank you for the quick review!

I'll need someone with commit access to land this change.

[lattner]

You can request commit access for yourself, just read the llvm developer policy for more info.

[trofi]

Rebased to get fast failed PE tests. No code changes.

[trofi]

Update author to personal email address.

llvm/lib/Transforms/IPO/FunctionImport.cpp

if (renameModuleForThinLTO(*SrcModule, Index, ClearDSOLocalOnDeclarations,
       return true;
 
     if (PrintImports) {
       for (const auto *GV : GlobalsToImport)
         dbgs() << DestModule.getSourceFileName() << ": Import " << GV->getName()
                << " from " << SrcModule->getSourceFileName() << "\n";
     }
 
-    if (Mover.move(std::move(SrcModule), GlobalsToImport.getArrayRef(),
-                   [](GlobalValue &, IRMover::ValueAdder) {},
-                   /*IsPerformingImport=*/true))
-      report_fatal_error("Function Import: link error");
+    if (Error Err = Mover.move(
+            std::move(SrcModule), GlobalsToImport.getArrayRef(),
+      report_fatal_error("Function Import: link error: " +
+                         toString(std::move(Err)));
 
     ImportedCount += GlobalsToImport.size();
     NumImportedModules++;
   }
 
   internalizeGVsAfterImport(DestModule);
 
   NumImportedFunctions += (ImportedCount - ImportedGVCount);