Page MenuHomePhabricator

[OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.
ClosedPublic

Authored by ABataev on Apr 22 2020, 7:20 AM.

Details

Summary

If the array subscript expression is type depent, its analysis must be
delayed before its instantiation.

Diff Detail

Unit TestsFailed

TimeTest
290 msClang Tools.clang-tidy/checkers::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; C:/Python38/python.exe C:/ws/workspace/amd64_windows_vs2017/llvm-project/clang-tools-extra/test/../test\clang-tidy\check_clang_tidy.py C:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers\abseil-duration-addition.cpp abseil-duration-addition C:\ws\workspace\amd64_windows_vs2017\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\checkers\Output\abseil-duration-addition.cpp.tmp -- -- -IC:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers/Inputs
250 msClang Tools.clang-tidy/checkers::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; C:/Python38/python.exe C:/ws/workspace/amd64_windows_vs2017/llvm-project/clang-tools-extra/test/../test\clang-tidy\check_clang_tidy.py C:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers\abseil-duration-comparison.cpp abseil-duration-comparison C:\ws\workspace\amd64_windows_vs2017\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\checkers\Output\abseil-duration-comparison.cpp.tmp -- -- -IC:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers/Inputs
240 msClang Tools.clang-tidy/checkers::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; C:/Python38/python.exe C:/ws/workspace/amd64_windows_vs2017/llvm-project/clang-tools-extra/test/../test\clang-tidy\check_clang_tidy.py C:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers\abseil-duration-factory-scale.cpp abseil-duration-factory-scale C:\ws\workspace\amd64_windows_vs2017\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\checkers\Output\abseil-duration-factory-scale.cpp.tmp -- -- -IC:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers/Inputs
250 msClang Tools.clang-tidy/checkers::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; C:/Python38/python.exe C:/ws/workspace/amd64_windows_vs2017/llvm-project/clang-tools-extra/test/../test\clang-tidy\check_clang_tidy.py C:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers\abseil-duration-subtraction.cpp abseil-duration-subtraction C:\ws\workspace\amd64_windows_vs2017\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\checkers\Output\abseil-duration-subtraction.cpp.tmp -- -- -I C:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers/Inputs
260 msClang Tools.clang-tidy/checkers::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; C:/Python38/python.exe C:/ws/workspace/amd64_windows_vs2017/llvm-project/clang-tools-extra/test/../test\clang-tidy\check_clang_tidy.py C:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers\abseil-time-comparison.cpp abseil-time-comparison C:\ws\workspace\amd64_windows_vs2017\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\checkers\Output\abseil-time-comparison.cpp.tmp -- -- -IC:\ws\workspace\amd64_windows_vs2017\llvm-project\clang-tools-extra\test\clang-tidy\checkers/Inputs
View Full Test Results (7 Failed)

Event Timeline

ABataev created this revision.Apr 22 2020, 7:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2020, 7:21 AM

Can we merge the test changes into D78643 and continue with D78643 as a fix?

This revision is now accepted and ready to land.Jun 3 2020, 12:12 PM
This revision was automatically updated to reflect the committed changes.