HomePhabricator

[x86] add test/code comment for chain value use (PR46195); NFC

Authored by spatel on Jun 4 2020, 5:50 AM.

Description

[x86] add test/code comment for chain value use (PR46195); NFC

Details

Committed
spatelJun 4 2020, 6:15 AM
Parents
rGf2c97656644e: [TableGen] Handle (outs variable_ops)
Branches
Unknown
Tags
Unknown

Event Timeline

rickyz added a subscriber: rickyz.Jun 4 2020, 6:40 AM
rickyz added inline comments.
/llvm/test/CodeGen/X86/load-chain.ll
8–22

I'm pretty new to how testing is usually done in LLVM - is it common to do exact matching against generated assembly? I was worried that unrelated changes affecting the generated code would need to update this test.

spatel marked 2 inline comments as done.Jun 4 2020, 7:20 AM
spatel added inline comments.
/llvm/test/CodeGen/X86/load-chain.ll
8–22

That's a valid concern. Exact matching does tend to increase test churn if someone wants to make an unrelated change for example to code scheduling or register allocation.

For x86 codegen, we are generally willing to do exact matching because it has proven useful even with the potential upkeep cost.

See PR22897 for background:
https://bugs.llvm.org/show_bug.cgi?id=22897