[libc][NFC] Cleanup dependencies in src/signal and test/src/signal.

[sivachandra]

There are other targets also which can be simplified. But, I am seeking feedback on the pattern I have followed in the signal directory as @abrachet setup the targets in this directory. If it looks good, I can extend it to other places as well.

[abrachet]

LG

libc/test/src/signal/CMakeLists.txt

20–24

Nit: we could put raise above sigaction like we do everywhere else.

Not for this patch, but It would be nice if all of our dependencies were alphabetical. I've not done a good job of that. I will look into if there is a programmatic way to have them ordered nicely.

35

Probably I should remove the line https://github.com/llvm/llvm-project/blob/master/libc/test/src/signal/sigprocmask_test.cpp#L36 and remove this too. But maybe not appropriate for this patch.

63

Ditto here and https://github.com/llvm/llvm-project/blob/master/libc/test/src/signal/signal_test.cpp#L22

[sivachandra]

libc/test/src/signal/CMakeLists.txt

20–24

Fixed this in the commit.

If you end up with something like a Python script which can formally parse our CMakeLists.txt files, that will be awesome and we can put it in say utils/buildutils.

35

Ack.

63

Ack.

libc/src/signal/linux/CMakeLists.txt

add_entrypoint_object(
   sigaction
   SRCS
     sigaction.cpp
   HDRS
     signal.h
     ../sigaction.h
   DEPENDS
     .__restore
-    .raise
     libc.config.linux.linux_syscall_h
     libc.include.signal
     libc.include.sys_syscall
+    libc.src.errno.__errno_location
 )
 
 add_entrypoint_object(
   sigprocmask
   SRCS
     sigprocmask.cpp
   HDRS
     signal.h

libc/test/src/signal/CMakeLists.txt

 )
 
 add_libc_unittest(
   sigaction_test
   SUITE
     libc_signal_unittests
   SRCS
     sigaction_test.cpp
   DEPENDS
-    libc.src.signal.sigaction
-    libc.src.signal.raise
-    libc.include.signal
     libc.include.errno
-    libc.src.errno.__errno_location
+    libc.include.signal
+    libc.src.signal.raise
+    libc.src.signal.sigaction
 )
 
 add_libc_unittest(
   sigprocmask_test
   SUITE
     libc_signal_unittests
   SRCS
     sigprocmask_test.cpp
   DEPENDS
-    libc.include.signal
+    libc.include.errno
     libc.src.errno.__errno_location
     libc.src.signal.raise
-    libc.src.signal.sigprocmask
     libc.src.signal.sigaddset
     libc.src.signal.sigemptyset
+    libc.src.signal.sigprocmask
 )
 
 add_libc_unittest(
   sigaddset_test
   SUITE
     libc_signal_unittests
   SRCS
     sigaddset_test.cpp
   DEPENDS
+    libc.include.errno
     libc.include.signal
-    libc.src.errno.__errno_location
     libc.src.signal.sigaddset
 )
 
 add_libc_unittest(
   signal_test
   SUITE
     libc_signal_unittests
   SRCS
     signal_test.cpp
   DEPENDS
     libc.include.errno
     libc.include.signal
     libc.src.errno.__errno_location
     libc.src.signal.raise
-    libc.src.signal.sigaction
     libc.src.signal.signal
 )
 
 add_libc_unittest(
   sigfillset_test
   SUITE
     libc_signal_unittests
   SRCS
     sigfillset_test.cpp
   DEPENDS
     libc.include.errno
     libc.include.signal
-    libc.src.errno.__errno_location
     libc.src.signal.raise
     libc.src.signal.sigfillset
     libc.src.signal.sigprocmask
 )
 
 add_libc_unittest(
   sigdelset_test
   SUITE
     libc_signal_unittests
   SRCS
     sigdelset_test.cpp
   DEPENDS
     libc.include.errno
     libc.include.signal
-    libc.src.errno.__errno_location
     libc.src.signal.raise
     libc.src.signal.sigdelset
     libc.src.signal.sigfillset
     libc.src.signal.sigprocmask
 )

libc/test/src/signal/sigaddset_test.cpp

 //===-- Unittests for sigaddset -------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "include/errno.h"
 #include "include/signal.h"
-#include "src/errno/llvmlibc_errno.h"
 #include "src/signal/sigaddset.h"
 
 #include "utils/UnitTest/ErrnoSetterMatcher.h"
 #include "utils/UnitTest/Test.h"
 
 // This tests invalid inputs and ensures errno is properly set.
 TEST(SignalTest, SigaddsetInvalid) {
   using __llvm_libc::testing::ErrnoSetterMatcher::Fails;