This is an archive of the discontinued LLVM Phabricator instance.

Differential D78450

CMake: Missing GlobalISel TableGen link
AcceptedPublic

Authored by jschueller on Apr 19 2020, 12:14 AM.

Details

Reviewers
dsanders
Summary

Sources from GlobalISel use symbols from TableGen:

  1. libLLVMTableGenGlobalISel.a(GIMatchTree.cpp.obj):GIMatchTree.cpp:(.text+0x8623): undefined reference to `llvm::PrintError(llvm::Twine const&)'

This fixes linking of llvm-tblgen on MinGW

Diff Detail

Event Timeline

jschueller created this revision.Apr 19 2020, 12:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2020, 12:14 AM
Herald added subscribers: llvm-commits, mstorsjo, rovka, mgorny. · View Herald Transcript
Harbormaster failed remote builds in B53890: Diff 258587!Apr 19 2020, 12:30 AM
dsanders accepted this revision.Apr 27 2020, 3:22 PM

I don't think it's safe to remove Support since llvm/lib/TableGen/CMakeLists.txt doesn't mention it but adding TableGen to the existing list would LGTM

This revision is now accepted and ready to land.Apr 27 2020, 3:22 PM

Revision Contents

PathSize
llvm/
utils/
TableGen/
GlobalISel/
2 lines

Diff 258587

llvm/utils/TableGen/GlobalISel/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support TableGen
) )
llvm_add_library(LLVMTableGenGlobalISel STATIC DISABLE_LLVM_LINK_LLVM_DYLIBllvm_add_library(LLVMTableGenGlobalISel STATIC DISABLE_LLVM_LINK_LLVM_DYLIB