Page MenuHomePhabricator

Perform ActOnConversionDeclarator after looking for any virtual functions it overrides
ClosedPublic

Authored by rdwampler on Apr 18 2020, 9:53 PM.

Details

Summary

This allows for suppressing warnings about the conversion function never being called if it overrides a virtual function in a base class.

Diff Detail

Event Timeline

rdwampler created this revision.Apr 18 2020, 9:53 PM

changed to check it overrides a virtual function in a base class and not just virtual.

LGTM with a minor fix.

clang/lib/Sema/SemaDecl.cpp
10748

Indentation is off.

Fixed indentation.

rdwampler marked an inline comment as done.Tue, May 12, 10:29 AM
rjmccall accepted this revision.Tue, May 12, 12:01 PM
This revision is now accepted and ready to land.Tue, May 12, 12:01 PM
This revision was automatically updated to reflect the committed changes.