Page MenuHomePhabricator

rdwampler (Ronald Wampler)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2017, 7:01 AM (136 w, 3 d)

Recent Activity

Fri, Sep 6

rdwampler committed rL371278: Request commit access for rdwampler.
Request commit access for rdwampler
Fri, Sep 6, 5:51 PM

Jul 30 2019

rdwampler added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

Is there sufficient test coverage as to what happens if SortPriority is not set?

If SortPriority is not set, the Includes will be grouped without sorting,

Let me rephrase - for the exiting .clang-formats, that don't currently specify SortPriority,
this introduction of SortPriority should not change the header handling.
Is that the case, and if so is there sufficient test coverage for that?

I got your idea now.
No, there is no test coverage for that case, and with the current patch they have to add SortPriority.
To avoid this shall I set SortPriority as Priority as default if it is not defined? I think that will fix the issue.

any reviews on it ?

Jul 30 2019, 7:12 AM · Restricted Project

Jul 17 2019

rdwampler added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

Thanks! Can you update the documentation too?

Jul 17 2019, 7:50 AM · Restricted Project

Jul 15 2019

rdwampler added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

Sorry, my mistake I meant that I have added Regex for priorities while sorting and If I am not wrong I think IncludeCategories are used while Regrouping after sorting the Includes. In addition to that in my case I have to sort the includes In a particular order then grouping them in different
For example:

#include <sys/param.h>		/* <sys/param.h> first, */
#include <sys/types.h>		/*   <sys/types.h> next, */
#include <sys/ioctl.h>		/*   and then the rest, */
#include <uvm/*.h>
#include <dev/*.h>

#include <net/if.h>
#include <net/if_dl.h>
#include <net/route.h>
#include <netinet/in.h>
#include <protocols/rwhod.h>

As shown in the above example <uvm> should follow <sys> then <dev> but while regrouping they should be in the same group.

Jul 15 2019, 10:40 AM · Restricted Project
rdwampler added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

I am not quite sure why this change is required to sort the headers for NetBSD, you can set the priorities via IncludeStyle.IncludeCategories. Is that not sufficient?

Jul 15 2019, 8:49 AM · Restricted Project

Mar 26 2019

rdwampler committed rGa83e2dbb1e19: [clang-format] Add style option AllowShortLambdasOnASingleLine (authored by rdwampler).
[clang-format] Add style option AllowShortLambdasOnASingleLine
Mar 26 2019, 1:17 PM
rdwampler committed rC357027: [clang-format] Add style option AllowShortLambdasOnASingleLine.
[clang-format] Add style option AllowShortLambdasOnASingleLine
Mar 26 2019, 1:17 PM
rdwampler committed rL357027: [clang-format] Add style option AllowShortLambdasOnASingleLine.
[clang-format] Add style option AllowShortLambdasOnASingleLine
Mar 26 2019, 1:17 PM
rdwampler closed D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.
Mar 26 2019, 1:16 PM · Restricted Project, Restricted Project
rdwampler committed rGbb7c57d36dd6: Test commit: fix typo (authored by rdwampler).
Test commit: fix typo
Mar 26 2019, 8:26 AM
rdwampler committed rL356999: Test commit: fix typo.
Test commit: fix typo
Mar 26 2019, 8:26 AM

Mar 24 2019

rdwampler added inline comments to D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Mar 24 2019, 12:15 PM · Restricted Project

Mar 22 2019

rdwampler added a comment to D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.

I don't have commit rights, can someone land this for me or would it be better to try and get commit access?

Mar 22 2019, 8:18 AM · Restricted Project, Restricted Project
rdwampler updated the diff for D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.

Rebased on master.

Mar 22 2019, 6:38 AM · Restricted Project, Restricted Project

Mar 20 2019

rdwampler added inline comments to D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.
Mar 20 2019, 9:00 PM · Restricted Project, Restricted Project
rdwampler updated the diff for D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.

Changes since last revision:

Mar 20 2019, 8:58 PM · Restricted Project, Restricted Project
rdwampler added a comment to D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.

Ping?

Mar 20 2019, 4:48 AM · Restricted Project, Restricted Project

Mar 6 2019

rdwampler added a comment to D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Ping? Can somebody commit this for me? Thanks!

Mar 6 2019, 8:13 AM · Restricted Project

Mar 4 2019

rdwampler added inline comments to D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.
Mar 4 2019, 8:42 AM · Restricted Project, Restricted Project

Feb 21 2019

rdwampler added a comment to D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Do you have permissions on the repo?

Feb 21 2019, 10:56 AM · Restricted Project

Feb 20 2019

rdwampler added a comment to D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Ping?

Feb 20 2019, 7:09 AM · Restricted Project

Feb 18 2019

rdwampler updated the diff for D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.
Feb 18 2019, 10:31 AM · Restricted Project, Restricted Project

Feb 13 2019

rdwampler created D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.
Feb 13 2019, 8:03 AM · Restricted Project

Feb 7 2019

rdwampler updated the diff for D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.

Update to include an option Inline to only put short lambda on a single line if used as an argument. See the following code style guide from catboost: ps://github.com/catboost/catboost/blob/master/CPP_STYLE_GUIDE.md#lambda-functions

Feb 7 2019, 1:01 PM · Restricted Project, Restricted Project

Feb 4 2019

rdwampler created D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.
Feb 4 2019, 7:24 AM · Restricted Project, Restricted Project

Nov 1 2017

rdwampler added inline comments to D39501: For pseudo-object assignment, don't wrap the RHS in a OVE if it's a prvalue.
Nov 1 2017, 12:50 PM
rdwampler created D39501: For pseudo-object assignment, don't wrap the RHS in a OVE if it's a prvalue.
Nov 1 2017, 12:49 PM

Oct 29 2017

rdwampler abandoned D39377: Avoid eliding the first operand in the gnu "x ?: y" extension.
Oct 29 2017, 7:21 AM

Oct 27 2017

rdwampler added a comment to D39377: Avoid eliding the first operand in the gnu "x ?: y" extension.

Thanks for the patch!

Side-comment: I wonder if ever need to copy-elide OpaqueValues. There could be similar issues that happen to OpaqueValue expression that we haven't uncovered yet.

Oct 27 2017, 8:27 PM
rdwampler created D39377: Avoid eliding the first operand in the gnu "x ?: y" extension.
Oct 27 2017, 11:00 AM

Jun 11 2017

rdwampler updated the diff for D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.

I was able to build and test this on a linux box. The issue was the whitespace surrounding the regex.

Jun 11 2017, 7:39 PM

Jun 9 2017

rdwampler added a comment to D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.

Alex, I will look into it. Thanks!

Jun 9 2017, 6:11 PM
rdwampler added a comment to D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.

I don't have commit access, but I would grateful if you can commit it.

Jun 9 2017, 11:16 AM
rdwampler updated the diff for D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.

Remove an unnecessary check when determining a mismatch of availabilities
Simplify invocation of FileCheck in availability.c

Jun 9 2017, 10:21 AM

Jun 7 2017

rdwampler added inline comments to D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.
Jun 7 2017, 5:39 PM
rdwampler updated the diff for D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.

This should resolve the bug (a conditional was inverted) in the last revision along with the other changes requested.

Jun 7 2017, 12:00 PM

Jun 6 2017

rdwampler updated the diff for D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.

Rearrange if statements in getCursorPlatformAvailabilityForDecl to return early if we do not need to merge availability attributes.
Use ranged for loop.

Jun 6 2017, 8:34 AM

Jun 2 2017

rdwampler added inline comments to D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.
Jun 2 2017, 9:36 AM
rdwampler added a reviewer for D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible: rsmith.
Jun 2 2017, 7:14 AM

May 23 2017

rdwampler created D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible.
May 23 2017, 7:56 PM

Feb 17 2017

rdwampler added a comment to D29455: [ADT] Delete orphaned doxygen comment in PriorityWorklist.

ping?

Feb 17 2017, 9:06 AM

Feb 2 2017

rdwampler created D29455: [ADT] Delete orphaned doxygen comment in PriorityWorklist.
Feb 2 2017, 7:47 AM