This is an archive of the discontinued LLVM Phabricator instance.

Differential D78410

[CMake] Set UBSAN_LINK_FLAGS for ubsan
ClosedPublic

Authored by phosek on Apr 17 2020, 5:36 PM.

Details

Reviewers
eugenis
vitalybuka
Commits
rG6919b708a180: [CMake] Set UBSAN_LINK_FLAGS for ubsan
Summary

This variable is being used, but it's not being set (it's only set
for ubsan_minimal, but not ubsan). This addresses a regression that
was introduced in D78325.

Diff Detail

Event Timeline

phosek created this revision.Apr 17 2020, 5:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2020, 5:36 PM
Herald added subscribers: Restricted Project, mgorny. · View Herald Transcript
Harbormaster failed remote builds in B53805: Diff 258456!Apr 17 2020, 5:41 PM
eugenis accepted this revision.Apr 17 2020, 9:55 PM

LGTM
Thanks!

This revision is now accepted and ready to land.Apr 17 2020, 9:55 PM
Closed by commit rG6919b708a180: [CMake] Set UBSAN_LINK_FLAGS for ubsan (authored by phosek). · Explain WhyApr 17 2020, 11:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
lib/
ubsan/
2 lines

Diff 258456

compiler-rt/lib/ubsan/CMakeLists.txt

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
set(UBSAN_STANDALONE_CFLAGS ${SANITIZER_COMMON_CFLAGS}) set(UBSAN_STANDALONE_CFLAGS ${SANITIZER_COMMON_CFLAGS})
append_rtti_flag(OFF UBSAN_STANDALONE_CFLAGS) append_rtti_flag(OFF UBSAN_STANDALONE_CFLAGS)
append_list_if(SANITIZER_CAN_USE_CXXABI -DUBSAN_CAN_USE_CXXABI UBSAN_STANDALONE_CFLAGS) append_list_if(SANITIZER_CAN_USE_CXXABI -DUBSAN_CAN_USE_CXXABI UBSAN_STANDALONE_CFLAGS)
set(UBSAN_CXXFLAGS ${SANITIZER_COMMON_CFLAGS}) set(UBSAN_CXXFLAGS ${SANITIZER_COMMON_CFLAGS})
append_rtti_flag(ON UBSAN_CXXFLAGS) append_rtti_flag(ON UBSAN_CXXFLAGS)
append_list_if(SANITIZER_CAN_USE_CXXABI -DUBSAN_CAN_USE_CXXABI UBSAN_CXXFLAGS) append_list_if(SANITIZER_CAN_USE_CXXABI -DUBSAN_CAN_USE_CXXABI UBSAN_CXXFLAGS)
set(UBSAN_LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS})
set(UBSAN_DYNAMIC_LIBS ${SANITIZER_CXX_ABI_LIBRARIES} ${SANITIZER_COMMON_LINK_LIBS}) set(UBSAN_DYNAMIC_LIBS ${SANITIZER_CXX_ABI_LIBRARIES} ${SANITIZER_COMMON_LINK_LIBS})
append_list_if(COMPILER_RT_HAS_LIBDL dl UBSAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBDL dl UBSAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBLOG log UBSAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBLOG log UBSAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBRT rt UBSAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBRT rt UBSAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread UBSAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread UBSAN_DYNAMIC_LIBS)
add_compiler_rt_component(ubsan) add_compiler_rt_component(ubsan)
▲ Show 20 Lines • Show All 188 Lines • Show Last 20 Lines