Instead of having different names for the same Lit feature accross code
bases, use the same name everywhere. This NFC commit is in preparation
for a refactor where all three projects will be using the same Lit
feature detection logic, and hence it won't be convenient to use
different names for the feature.
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project Restricted Project Restricted Project - Commits
- rG8c61114c53dc: [libc++/abi/unwind] Rename Lit features for no exceptions to 'no-exceptions'
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This is a very simple change, but I wanted to ask whether someone was aware of a reason for having different names for libcxx-no-exceptions and libcxxabi-no-exceptions.
no-exceptions sounds a bit better to me as a feature name rather than the Clang command-line argument, although what you have is probably okay too. (Unifying sounds great! I'll let someone else sign off though.)
We use -fmeow for other Lit features in libc++ pretty widely (e.g. -fmodules). I agree with you though, and I was planning on changing the names of many features once I'm done with the changes started in https://reviews.llvm.org/D78381.
Since this is NFC and I put up a review just to ask whether folks were aware of a reason for having different Lit feature names, I'll assume the answer is "there's no reason" and commit this tomorrow unless someone raises an issue.