This is an archive of the discontinued LLVM Phabricator instance.

[libc++/abi/unwind] Rename Lit features for no exceptions to -fno-exceptions
ClosedPublic

Authored by ldionne on Apr 17 2020, 7:33 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Commits
rG8c61114c53dc: [libc++/abi/unwind] Rename Lit features for no exceptions to 'no-exceptions'
Summary

Instead of having different names for the same Lit feature accross code
bases, use the same name everywhere. This NFC commit is in preparation
for a refactor where all three projects will be using the same Lit
feature detection logic, and hence it won't be convenient to use
different names for the feature.

Diff Detail

Event Timeline

ldionne created this revision.Apr 17 2020, 7:33 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptApr 17 2020, 7:34 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript

This is a very simple change, but I wanted to ask whether someone was aware of a reason for having different names for libcxx-no-exceptions and libcxxabi-no-exceptions.

no-exceptions sounds a bit better to me as a feature name rather than the Clang command-line argument, although what you have is probably okay too. (Unifying sounds great! I'll let someone else sign off though.)

no-exceptions sounds a bit better to me as a feature name rather than the Clang command-line argument, although what you have is probably okay too. (Unifying sounds great! I'll let someone else sign off though.)

We use -fmeow for other Lit features in libc++ pretty widely (e.g. -fmodules). I agree with you though, and I was planning on changing the names of many features once I'm done with the changes started in https://reviews.llvm.org/D78381.

ldionne updated this revision to Diff 258722.Apr 20 2020, 6:48 AM

Rename to no-exceptions.

ldionne accepted this revision.Apr 21 2020, 10:04 AM

Since this is NFC and I put up a review just to ask whether folks were aware of a reason for having different Lit feature names, I'll assume the answer is "there's no reason" and commit this tomorrow unless someone raises an issue.

ldionne accepted this revision.Apr 22 2020, 5:01 AM
This revision is now accepted and ready to land.Apr 22 2020, 5:01 AM
This revision was automatically updated to reflect the committed changes.