This is an archive of the discontinued LLVM Phabricator instance.

Differential D78303

[MLIR] Fix MLIR build - add missing CMake dependency
ClosedPublic

Authored by bondhugula on Apr 16 2020, 8:12 AM.

Details

Reviewers
mehdi_amini
nicolasvasilache
Commits
rGea88dd821253: [MLIR] Fix MLIR build - add missing CMake dependency
Summary

This will fix failure using a linker sensitive to the order in which
libraries are passed.

Diff Detail

Event Timeline

bondhugula created this revision.Apr 16 2020, 8:12 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 16 2020, 8:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, frgossen, grosul1 and 13 others. · View Herald Transcript
Harbormaster failed remote builds in B53571: Diff 258060!Apr 16 2020, 8:22 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2020, 8:55 AM
Closed by commit rGea88dd821253: [MLIR] Fix MLIR build - add missing CMake dependency (authored by bondhugula). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Dialect/
Affine/
Utils/
1 line

Diff 258068

mlir/lib/Dialect/Affine/Utils/CMakeLists.txt

add_mlir_dialect_library(MLIRAffineUtils add_mlir_dialect_library(MLIRAffineUtils
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Affine
) )
target_link_libraries(MLIRAffineUtils target_link_libraries(MLIRAffineUtils
PUBLIC PUBLIC
MLIRAffine MLIRAffine
MLIRTransformUtils
) )