This is an archive of the discontinued LLVM Phabricator instance.

Differential D78227

[CallSite removal][SimpleLoopUnswitch] Use CallBase instead of CallSite. NFC
ClosedPublic

Authored by craig.topper on Apr 15 2020, 11:38 AM.

Details

Reviewers
dblaikie
mtrofin
Commits
rG592d8e7d75cf: [CallSite removal][SimpleLoopUnswitch] Use CallBase instead of CallSite. NFC

Diff Detail

Event Timeline

craig.topper created this revision.Apr 15 2020, 11:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2020, 11:38 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster failed remote builds in B53396: Diff 257785!Apr 15 2020, 12:04 PM
mtrofin accepted this revision.Apr 15 2020, 12:24 PM

lgtm

This revision is now accepted and ready to land.Apr 15 2020, 12:24 PM
Closed by commit rG592d8e7d75cf: [CallSite removal][SimpleLoopUnswitch] Use CallBase instead of CallSite. NFC (authored by craig.topper). · Explain WhyApr 15 2020, 1:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Scalar/
4 lines

Diff 257785

llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp

///===- SimpleLoopUnswitch.cpp - Hoist loop-invariant control flow ---------===// ///===- SimpleLoopUnswitch.cpp - Hoist loop-invariant control flow ---------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 2,642 Lines • ▼ Show 20 LinesunswitchBestCondition(Loop &L, DominatorTree &DT, LoopInfo &LI,
for (auto *BB : L.blocks()) { for (auto *BB : L.blocks()) {
int Cost = 0; int Cost = 0;
for (auto &I : *BB) { for (auto &I : *BB) {
if (EphValues.count(&I)) if (EphValues.count(&I))
continue; continue;
if (I.getType()->isTokenTy() && I.isUsedOutsideOfBlock(BB)) if (I.getType()->isTokenTy() && I.isUsedOutsideOfBlock(BB))
return false; return false;
if (auto CS = CallSite(&I)) if (auto *CB = dyn_cast<CallBase>(&I))
if (CS.isConvergent() || CS.cannotDuplicate()) if (CB->isConvergent() || CB->cannotDuplicate())
return false; return false;
Cost += TTI.getUserCost(&I); Cost += TTI.getUserCost(&I);
} }
assert(Cost >= 0 && "Must not have negative costs!"); assert(Cost >= 0 && "Must not have negative costs!");
LoopCost += Cost; LoopCost += Cost;
assert(LoopCost >= 0 && "Must not have negative loop costs!"); assert(LoopCost >= 0 && "Must not have negative loop costs!");
BBCostMap[BB] = Cost; BBCostMap[BB] = Cost;
▲ Show 20 Lines • Show All 339 Lines • Show Last 20 Lines