This is an archive of the discontinued LLVM Phabricator instance.

Differential D78182

[CallSite removal][PruneEH] Use CallBase instead of CallSite. NFC
ClosedPublic

Authored by craig.topper on Apr 15 2020, 12:27 AM.

Details

Reviewers
mtrofin
dblaikie
Commits
rGa0d92248eaed: [CallSite removal][PruneEH] Use CallBase instead of CallSite. NFC

Diff Detail

Event Timeline

craig.topper created this revision.Apr 15 2020, 12:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2020, 12:27 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster completed remote builds in B53304: Diff 257612.Apr 15 2020, 1:03 AM
mtrofin accepted this revision.Apr 15 2020, 7:53 AM

lgtm

This revision is now accepted and ready to land.Apr 15 2020, 7:53 AM
Closed by commit rGa0d92248eaed: [CallSite removal][PruneEH] Use CallBase instead of CallSite. NFC (authored by craig.topper). · Explain WhyApr 15 2020, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
4 lines

Diff 257612

llvm/lib/Transforms/IPO/PruneEH.cpp

//===- PruneEH.cpp - Pass which deletes unused exception handlers ---------===// //===- PruneEH.cpp - Pass which deletes unused exception handlers ---------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 121 Lines • ▼ Show 20 Lines if (!F) {
// because it might. If it is inside, do nothing. // because it might. If it is inside, do nothing.
if (SCCNodes.count(CalleeNode) > 0) if (SCCNodes.count(CalleeNode) > 0)
InstMightUnwind = false; InstMightUnwind = false;
} }
} }
SCCMightUnwind |= InstMightUnwind; SCCMightUnwind |= InstMightUnwind;
} }
if (CheckReturnViaAsm && !SCCMightReturn) if (CheckReturnViaAsm && !SCCMightReturn)
if (auto ICS = ImmutableCallSite(&I)) if (const auto *CB = dyn_cast<CallBase>(&I))
if (const auto *IA = dyn_cast<InlineAsm>(ICS.getCalledValue())) if (const auto *IA = dyn_cast<InlineAsm>(CB->getCalledValue()))
if (IA->hasSideEffects()) if (IA->hasSideEffects())
SCCMightReturn = true; SCCMightReturn = true;
} }
if (SCCMightUnwind && SCCMightReturn) if (SCCMightUnwind && SCCMightReturn)
break; break;
} }
} }
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines