This is an archive of the discontinued LLVM Phabricator instance.

[clangd][test] Provide registered targets to lit tests
ClosedPublic

Authored by kadircet on Apr 11 2020, 8:23 AM.

Details

Summary

We had tests in clangd (target_info.test) that got enabled only on
systems that know about x86. But they were always disabled as clangd lit config
never registered those targets.

This patch adds those targets as $TARGET$-registered-target

Diff Detail

Event Timeline

kadircet created this revision.Apr 11 2020, 8:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2020, 8:23 AM
sammccall accepted this revision.Apr 11 2020, 8:34 AM
sammccall added inline comments.
clang-tools-extra/clangd/test/lit.cfg.py
17

nit: is this return [arch.lower() + '-registered-target' for arch in arch_string.split()]?

This revision is now accepted and ready to land.Apr 11 2020, 8:34 AM
This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.