This is an archive of the discontinued LLVM Phabricator instance.

Differential D77917

[mlir][toy] Fix comment typo. NFC
ClosedPublic

Authored by jroelofs on Apr 10 2020, 3:51 PM.

Download Raw Diff

Details

Reviewers

Commits

rG015ebd2930bd: [mlir][toy] Fix comment typo. NFC

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jroelofs created this revision.Apr 10 2020, 3:51 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2020, 3:51 PM

Herald added subscribers: llvm-commits, frgossen, grosul1 and 12 others. · View Herald Transcript

Harbormaster failed remote builds in B52754: Diff 256695!Apr 10 2020, 4:42 PM

(Feel free to skip pre-commit review for this)

This revision is now accepted and ready to land.Apr 10 2020, 6:36 PM

In D77917#1975666, @mehdi_amini wrote:

(Feel free to skip pre-commit review for this)

normally would, but I wanted to experiment with arcanist

015ebd2930bd07bc535769eae2184e9ae2f3c86a

Revision Contents

Path

Size

mlir/

examples/

toy/

Ch6/

mlir/

LowerToLLVM.cpp

2 lines

Ch7/

mlir/

LowerToLLVM.cpp

2 lines

Diff 256695

mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp

	Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines
	void ToyToLLVMLoweringPass::runOnOperation() {			void ToyToLLVMLoweringPass::runOnOperation() {
	// The first thing to define is the conversion target. This will define the			// The first thing to define is the conversion target. This will define the
	// final target for this lowering. For this lowering, we are only targeting			// final target for this lowering. For this lowering, we are only targeting
	// the LLVM dialect.			// the LLVM dialect.
	LLVMConversionTarget target(getContext());			LLVMConversionTarget target(getContext());
	target.addLegalOp<ModuleOp, ModuleTerminatorOp>();			target.addLegalOp<ModuleOp, ModuleTerminatorOp>();

	// During this lowering, we will also be lowering the MemRef types, that are			// During this lowering, we will also be lowering the MemRef types, that are
	// currently being operated on, to a representation in LLVM. Do perform this			// currently being operated on, to a representation in LLVM. To perform this
	// conversion we use a TypeConverter as part of the lowering. This converter			// conversion we use a TypeConverter as part of the lowering. This converter
	// details how one type maps to another. This is necessary now that we will be			// details how one type maps to another. This is necessary now that we will be
	// doing more complicated lowerings, involving loop region arguments.			// doing more complicated lowerings, involving loop region arguments.
	LLVMTypeConverter typeConverter(&getContext());			LLVMTypeConverter typeConverter(&getContext());

	// Now that the conversion target has been defined, we need to provide the			// Now that the conversion target has been defined, we need to provide the
	// patterns used for lowering. At this point of the compilation process, we			// patterns used for lowering. At this point of the compilation process, we
	// have a combination of `toy`, `affine`, and `std` operations. Luckily, there			// have a combination of `toy`, `affine`, and `std` operations. Luckily, there
	Show All 26 Lines

mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp

	Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines
	void ToyToLLVMLoweringPass::runOnOperation() {			void ToyToLLVMLoweringPass::runOnOperation() {
	// The first thing to define is the conversion target. This will define the			// The first thing to define is the conversion target. This will define the
	// final target for this lowering. For this lowering, we are only targeting			// final target for this lowering. For this lowering, we are only targeting
	// the LLVM dialect.			// the LLVM dialect.
	LLVMConversionTarget target(getContext());			LLVMConversionTarget target(getContext());
	target.addLegalOp<ModuleOp, ModuleTerminatorOp>();			target.addLegalOp<ModuleOp, ModuleTerminatorOp>();

	// During this lowering, we will also be lowering the MemRef types, that are			// During this lowering, we will also be lowering the MemRef types, that are
	// currently being operated on, to a representation in LLVM. Do perform this			// currently being operated on, to a representation in LLVM. To perform this
	// conversion we use a TypeConverter as part of the lowering. This converter			// conversion we use a TypeConverter as part of the lowering. This converter
	// details how one type maps to another. This is necessary now that we will be			// details how one type maps to another. This is necessary now that we will be
	// doing more complicated lowerings, involving loop region arguments.			// doing more complicated lowerings, involving loop region arguments.
	LLVMTypeConverter typeConverter(&getContext());			LLVMTypeConverter typeConverter(&getContext());

	// Now that the conversion target has been defined, we need to provide the			// Now that the conversion target has been defined, we need to provide the
	// patterns used for lowering. At this point of the compilation process, we			// patterns used for lowering. At this point of the compilation process, we
	// have a combination of `toy`, `affine`, and `std` operations. Luckily, there			// have a combination of `toy`, `affine`, and `std` operations. Luckily, there
	Show All 26 Lines