This is an archive of the discontinued LLVM Phabricator instance.

Differential D77914

[mlir][docs] Explain the EDSC acronym. NFC
ClosedPublic

Authored by jroelofs on Apr 10 2020, 3:41 PM.

Details

Reviewers
rriddle
mehdi_amini
Commits
rG0dbaafaa3a6a: [mlir][docs] Explain the EDSC acronym. NFC

Diff Detail

Event Timeline

jroelofs created this revision.Apr 10 2020, 3:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2020, 3:41 PM
Herald added subscribers: llvm-commits, frgossen, grosul1 and 13 others. · View Herald Transcript
jroelofs abandoned this revision.Apr 10 2020, 3:42 PM

Arc didn't do what I wanted here. I'll re-submit.

jroelofs updated this revision to Diff 256693.Apr 10 2020, 3:50 PM

re-submitting

jroelofs updated this revision to Diff 256696.Apr 10 2020, 3:52 PM

(sorry for the noise, I'm learning how to use arcanist)

jroelofs added a reviewer: rriddle.Apr 10 2020, 3:53 PM
jroelofs updated this revision to Diff 256701.Apr 10 2020, 4:13 PM

s/Compiler/Constructs/

Harbormaster completed remote builds in B52750: Diff 256691.Apr 10 2020, 4:42 PM
Harbormaster completed remote builds in B52752: Diff 256693.
Harbormaster completed remote builds in B52755: Diff 256696.
Harbormaster completed remote builds in B52760: Diff 256701.Apr 10 2020, 5:15 PM
mehdi_amini accepted this revision.Apr 10 2020, 8:20 PM
mehdi_amini added inline comments.
llvm/docs/Lexicon.rst
102 ↗(On Diff #256701)

Seems like you should put it there: https://github.com/llvm/mlir-www/edit/master/website/content/getting_started/Glossary.md

This revision is now accepted and ready to land.Apr 10 2020, 8:20 PM
jroelofs marked 2 inline comments as done.Apr 11 2020, 8:09 AM
jroelofs added inline comments.
llvm/docs/Lexicon.rst
102 ↗(On Diff #256701)

Good call. https://github.com/llvm/mlir-www/pull/20

jroelofs updated this revision to Diff 256773.Apr 11 2020, 8:10 AM
jroelofs marked an inline comment as done.

Move LLVM Lexicon entry out to MLIR Glossary

jroelofs closed this revision.Apr 11 2020, 8:18 AM

0dbaafaa3a6ac81b1e117972ecda7cbb7424039e

Harbormaster failed remote builds in B52805: Diff 256773!Apr 11 2020, 9:03 AM

Revision Contents

PathSize
mlir/
docs/
7 lines

Diff 256773

mlir/docs/EDSC.md

# Background: declarative builders API # Background: declarative builders API
The main purpose of the declarative builders API is to provide an intuitive way The main purpose of the declarative builders API is to provide an intuitive way
of constructing MLIR programmatically. In the majority of cases, the IR we wish of constructing MLIR programmatically. In the majority of cases, the IR we wish
to construct exhibits structured control-flow. Declarative builders provide an to construct exhibits structured control-flow. The Declarative builders in the
API to make MLIR construction and manipulation very idiomatic, for the `EDSC` library (Embedded Domain Specific Constructs) provide an API to make MLIR
structured control-flow case, in C++. construction and manipulation very idiomatic, for the structured control-flow
case, in C++.
## ScopedContext ## ScopedContext
`mlir::edsc::ScopedContext` provides an implicit thread-local context, `mlir::edsc::ScopedContext` provides an implicit thread-local context,
supporting a simple declarative API with globally accessible builders. These supporting a simple declarative API with globally accessible builders. These
declarative builders are available within the lifetime of a `ScopedContext`. declarative builders are available within the lifetime of a `ScopedContext`.
## ValueHandle and IndexHandle ## ValueHandle and IndexHandle
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines