Previously the value of Python3_ROOT_DIR was set to the string
"PYTHON_HOME" instead of the value of the variable named
PYTHON_HOME. This commit fixes that as CMake expects
a path as the value of Python3_ROOT_DIR
Details
Details
- Reviewers
JDevlieghere teemperor - Group Reviewers
Restricted Project - Commits
- rG664fda72eaa3: Fix setting Python3_ROOT_DIR on Windows
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
The intention of the code is to set the variable Python3_ROOT_DIR to the value of the variable PYTHON_HOME, but it was using just the string "PYTHON_HOME" instead.
Comment Actions
LGTM, PYTHON_HOME is apparently the Windows way we allow people to specify the python root when finding the package.
Please update the review description though with why this change was done that this isn't just documented in the comments here.