Page MenuHomePhabricator

[libunwind] Clean up __arm64__
ClosedPublic

Authored by MaskRay on Apr 9 2020, 2:22 PM.

Details

Reviewers
ldionne
scw
mstorsjo
Group Reviewers
Restricted Project
Commits
rGf3d460ce5874: [libunwind] Clean up __arm64__
Summary

__aarch64__ is defined for the target (since the beginning of arm64 support: clang 3.5).
__arm64__ is only defined for the Darwin OS on AArch64.

defined(__aarch64__) || defined(__arm64__) can be simplied as defined(__aarch64__)

Darwin AArch64 uses %% as the assembly separator (see AArch64MCAsmInfo.cpp).
Make the intention explicit in src/assembly.h

With this change, the libunwind code base has no reference of __arm64__/__arm64.

Diff Detail

Event Timeline

MaskRay created this revision.Apr 9 2020, 2:22 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 9 2020, 2:22 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
MaskRay edited the summary of this revision. (Show Details)Apr 9 2020, 2:23 PM
ldionne accepted this revision.Apr 9 2020, 2:32 PM

This LGTM.

(but not a code owner for libunwind)

mstorsjo accepted this revision.Apr 9 2020, 3:09 PM

LGTM

This revision is now accepted and ready to land.Apr 9 2020, 3:09 PM
This revision was automatically updated to reflect the committed changes.