This is an archive of the discontinued LLVM Phabricator instance.

Differential D77781

[libc] Change minimum cmake requirement.
ClosedPublic

Authored by PaulkaToast on Apr 9 2020, 12:27 AM.

Details

Reviewers
sivachandra
Commits
rGbe54ea52f1f5: [libc] Change minimum cmake requirement.
Summary

As per this thread: http://lists.llvm.org/pipermail/llvm-dev/2020-April/140744.html, changed the minimum requirement to reflect the decision made to upgrade to cmake 3.13.4.

Diff Detail

Unit TestsFailed

TimeTest
450 msLLVM.Transforms/Attributor::Unknown Unit Message ("")
300 msLLVM.Transforms/Attributor::Unknown Unit Message ("")
100 msLLVM.Transforms/Attributor/ArgumentPromotion::Unknown Unit Message ("")

Event Timeline

PaulkaToast created this revision.Apr 9 2020, 12:27 AM
Herald added subscribers: libc-commits, tschuett, mgorny. · View Herald TranscriptApr 9 2020, 12:27 AM
PaulkaToast mentioned this in D75027: [libc] Guard cmake policy to avoid errors on older versions of cmake..Apr 9 2020, 12:28 AM
Harbormaster failed remote builds in B52462: Diff 256204!Apr 9 2020, 1:03 AM
sivachandra accepted this revision.Apr 9 2020, 10:11 AM
This revision is now accepted and ready to land.Apr 9 2020, 10:11 AM
Closed by commit rGbe54ea52f1f5: [libc] Change minimum cmake requirement. (authored by PaulkaToast). · Explain WhyApr 9 2020, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libc/
2 lines

Diff 256204

libc/CMakeLists.txt

cmake_minimum_required(VERSION 3.4.3) cmake_minimum_required(VERSION 3.13.4)
# Use old version of target_sources command which converts the source # Use old version of target_sources command which converts the source
# file paths to full paths. # file paths to full paths.
cmake_policy(SET CMP0076 OLD) cmake_policy(SET CMP0076 OLD)
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules") list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
# The top-level source directory of libc. # The top-level source directory of libc.
set(LIBC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(LIBC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
Show All 33 Lines