This is an archive of the discontinued LLVM Phabricator instance.

Differential D77726

[MLIR] Fix more gcc-5 build failure issues by D77528
ClosedPublic

Authored by bondhugula on Apr 8 2020, 6:45 AM.

Details

Reviewers
ftynse
Commits
rG3156b5422e6c: [MLIR] Fix more gcc-5 build issues from D77528
Summary

820c420d4e1c630b5ead285917c6ecdd2f5092ad did not really fix all build
issues by D77528. This gets rid of two unnecessary 'using' declarations.

Diff Detail

Event Timeline

bondhugula created this revision.Apr 8 2020, 6:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2020, 6:45 AM
Herald added subscribers: llvm-commits, frgossen, grosul1 and 12 others. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2020, 7:02 AM
Closed by commit rG3156b5422e6c: [MLIR] Fix more gcc-5 build issues from D77528 (authored by bondhugula). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B52349: Diff 256007!Apr 8 2020, 7:03 AM
bondhugula mentioned this in D77528: [MLIR] Add support to use aligned_alloc to lower AllocOp from std to llvm.Apr 8 2020, 7:15 AM

Revision Contents

PathSize
mlir/
lib/
Conversion/
StandardToLLVM/
2 lines

Diff 256007

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

Show First 20 Lines • Show All 1,235 Lines • ▼ Show 20 Linesstatic bool isSupportedMemRefType(MemRefType type) {
return type.getAffineMaps().empty() || return type.getAffineMaps().empty() ||
llvm::all_of(type.getAffineMaps(), llvm::all_of(type.getAffineMaps(),
[](AffineMap map) { return map.isIdentity(); }); [](AffineMap map) { return map.isIdentity(); });
} }
/// Lowering for AllocOp and AllocaOp. /// Lowering for AllocOp and AllocaOp.
template <typename AllocLikeOp> template <typename AllocLikeOp>
struct AllocLikeOpLowering : public ConvertOpToLLVMPattern<AllocLikeOp> { struct AllocLikeOpLowering : public ConvertOpToLLVMPattern<AllocLikeOp> {
using ConvertOpToLLVMPattern<AllocLikeOp>::ConvertOpToLLVMPattern;
using Base = AllocLikeOpLowering<AllocLikeOp>;
using ConvertOpToLLVMPattern<AllocLikeOp>::createIndexConstant; using ConvertOpToLLVMPattern<AllocLikeOp>::createIndexConstant;
using ConvertOpToLLVMPattern<AllocLikeOp>::getIndexType; using ConvertOpToLLVMPattern<AllocLikeOp>::getIndexType;
using ConvertOpToLLVMPattern<AllocLikeOp>::typeConverter; using ConvertOpToLLVMPattern<AllocLikeOp>::typeConverter;
using ConvertOpToLLVMPattern<AllocLikeOp>::getVoidPtrType; using ConvertOpToLLVMPattern<AllocLikeOp>::getVoidPtrType;
explicit AllocLikeOpLowering(LLVMTypeConverter &converter, explicit AllocLikeOpLowering(LLVMTypeConverter &converter,
bool useAlignedAlloc = false) bool useAlignedAlloc = false)
: ConvertOpToLLVMPattern<AllocLikeOp>(converter), : ConvertOpToLLVMPattern<AllocLikeOp>(converter),
▲ Show 20 Lines • Show All 1,742 Lines • Show Last 20 Lines