Details
Details
- Reviewers
kadircet
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
| Time | Test | |
|---|---|---|
| 120 ms | lldb-unit.Host/_/HostTests::Unknown Unit Message (" ") Note: Google Test filter = ConnectionFileDescriptorTest.TCPGetURIv6
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
|
Event Timeline
Comment Actions
we should also be handling LabelDecls in clang/lib/Index/IndexDecl.cpp
| clang/lib/Index/IndexBody.cpp | ||
|---|---|---|
| 145 | this should propagate the result from handleReference, i.e return IndexCtx.handleRefer.... | |
| 146 | s/unsigned/SymbolRoleSet | |
| 154 | the two comments above also applies to this one. | |
| clang/unittests/Index/IndexTests.cpp | ||
| 355 | nit: just Not(Contains(QName("label")) | |
| clang/lib/Index/IndexBody.cpp | ||
|---|---|---|
| 152 | argh, looks like RecursiveASTVisitor doesn't traverse LabelDecl inside the LabelStmt. So feel free to fix that in RAV or call IndexCtx.handleDecl(LabelDecl) in here with a fixme. (hopefully nothing much should break with the former though) | |
| clang/unittests/Index/IndexTests.cpp | ||
| 349 | i believe we should see the "definition/declaration" of label rather than a reference | |