This is an archive of the discontinued LLVM Phabricator instance.

Fix a typo in clang/lib/Frontend/FrontendAction.cpp
ClosedPublic

Authored by rZhBoYao on Apr 6 2020, 1:43 AM.

Download Raw Diff

Details

Reviewers

rsmith
harlanhaskins
aaron.ballman

Group Reviewers

Restricted Project

Summary

There is a typo in clang/lib/Frontend/FrontendAction.cpp.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rZhBoYao created this revision.Apr 6 2020, 1:43 AM

revert the change to trailing newlines

Harbormaster completed remote builds in B51896: Diff 255251.Apr 6 2020, 2:40 AM

Harbormaster completed remote builds in B51897: Diff 255254.

LGTM! Do you need someone to commit on your behalf?

This revision is now accepted and ready to land.Apr 6 2020, 4:27 AM

In D77532#1963551, @aaron.ballman wrote:

LGTM! Do you need someone to commit on your behalf?

Yes, much appreciated!

Thank you for the patch! I've committed on your behalf in 2aa593be5486a9c5d3092647f2576273f84f3159

Revision Contents

Path

Size

clang/

lib/

Frontend/

FrontendAction.cpp

3 lines

Diff 255251

clang/lib/Frontend/FrontendAction.cpp

Show First 20 Lines • Show All 781 Lines • ▼ Show 20 Lines	else {
auto Buffer = getInputBufferForModule(CI, CurrentModule);		auto Buffer = getInputBufferForModule(CI, CurrentModule);
if (!Buffer)		if (!Buffer)
goto failure;		goto failure;

// Reinitialize the main file entry to refer to the new input.		// Reinitialize the main file entry to refer to the new input.
auto Kind = CurrentModule->IsSystem ? SrcMgr::C_System : SrcMgr::C_User;		auto Kind = CurrentModule->IsSystem ? SrcMgr::C_System : SrcMgr::C_User;
auto &SourceMgr = CI.getSourceManager();		auto &SourceMgr = CI.getSourceManager();
auto BufferID = SourceMgr.createFileID(std::move(Buffer), Kind);		auto BufferID = SourceMgr.createFileID(std::move(Buffer), Kind);
assert(BufferID.isValid() && "couldn't creaate module buffer ID");		assert(BufferID.isValid() && "couldn't create module buffer ID");
SourceMgr.setMainFileID(BufferID);		SourceMgr.setMainFileID(BufferID);
}		}
}		}

// Initialize the action.		// Initialize the action.
if (!BeginSourceFileAction(CI))		if (!BeginSourceFileAction(CI))
goto failure;		goto failure;

▲ Show 20 Lines • Show All 303 Lines • ▼ Show 20 Lines
}		}
bool WrapperFrontendAction::hasCodeCompletionSupport() const {		bool WrapperFrontendAction::hasCodeCompletionSupport() const {
return WrappedAction->hasCodeCompletionSupport();		return WrappedAction->hasCodeCompletionSupport();
}		}

WrapperFrontendAction::WrapperFrontendAction(		WrapperFrontendAction::WrapperFrontendAction(
std::unique_ptr<FrontendAction> WrappedAction)		std::unique_ptr<FrontendAction> WrappedAction)
: WrappedAction(std::move(WrappedAction)) {}		: WrappedAction(std::move(WrappedAction)) {}