Page MenuHomePhabricator

rZhBoYao (PoYao Chang)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2020, 12:32 AM (147 w, 4 d)

Recent Activity

Dec 9 2022

rZhBoYao added a reviewer for D139586: [Clang][C++23] Lifetime extension in range-based for loops: erichkeane.
Dec 9 2022, 3:31 AM · Restricted Project, Restricted Project

Dec 7 2022

rZhBoYao added a comment to D139586: [Clang][C++23] Lifetime extension in range-based for loops.

Consider:

struct T {
  const int *begin() const;
  const int *end()   const;
  T &r() [[clang::lifetimebound]];
  T t();
};
Dec 7 2022, 3:11 PM · Restricted Project, Restricted Project
rZhBoYao requested review of D139586: [Clang][C++23] Lifetime extension in range-based for loops.
Dec 7 2022, 2:54 PM · Restricted Project, Restricted Project

Apr 11 2022

rZhBoYao committed rG50b1faf5c188: [Clang] CWG 1394: Incomplete types as parameters of deleted functions (authored by rZhBoYao).
[Clang] CWG 1394: Incomplete types as parameters of deleted functions
Apr 11 2022, 8:18 PM · Restricted Project, Restricted Project
rZhBoYao committed rG369c5fa17be0: [NFC][Clang] Use previously declared variable instead of calling function… (authored by rZhBoYao).
[NFC][Clang] Use previously declared variable instead of calling function…
Apr 11 2022, 8:18 PM · Restricted Project, Restricted Project
rZhBoYao closed D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 11 2022, 8:18 PM · Restricted Project, Restricted Project

Apr 8 2022

rZhBoYao added a comment to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Revisiting @ChuanqiXu 's code suggestion...

Apr 8 2022, 2:21 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Reordered enumerators.

Apr 8 2022, 10:59 AM · Restricted Project, Restricted Project

Apr 7 2022

rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 10:54 PM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 10:28 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Added release note.

Apr 7 2022, 3:02 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Updating the status of CWG 1394 is the only change.

Apr 7 2022, 2:33 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Removed member function test cases and addressed comments,
which includes:

  1. Sema::SetFunctionBodyKind
  2. Change enum names
  3. Be clear about delete being C++ specific.
Apr 7 2022, 1:31 PM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 11:46 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Handling of eagerly parsed deleted or defaulted function must happen AFTER D.complete(Res);.

Apr 7 2022, 11:44 AM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 11:41 AM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 11:15 AM · Restricted Project, Restricted Project

Apr 6 2022

rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

I think an extra parameter is inevitable without complicating things too much.

Apr 6 2022, 3:28 AM · Restricted Project, Restricted Project

Apr 5 2022

rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 5 2022, 8:14 PM · Restricted Project, Restricted Project

Apr 2 2022

rZhBoYao updated the summary of D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 2 2022, 6:15 PM · Restricted Project, Restricted Project
rZhBoYao added a reviewer for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions: rtrieu.
Apr 2 2022, 10:41 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 2 2022, 9:11 AM · Restricted Project, Restricted Project

Mar 23 2022

rZhBoYao committed rG355f1c75aa66: [Clang] Fix PR28101 (authored by rZhBoYao).
[Clang] Fix PR28101
Mar 23 2022, 9:39 AM · Restricted Project
rZhBoYao closed D115248: [Clang] Fix PR28101.
Mar 23 2022, 9:39 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

Added an entry in release notes. Waiting for CI...

Mar 23 2022, 9:05 AM · Restricted Project, Restricted Project
rZhBoYao added a comment to D115248: [Clang] Fix PR28101.

By 'release notes' do you mean a more detailed commit message?

Mar 23 2022, 8:37 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

This passes check-clang-semacxx on my machine.

Mar 23 2022, 8:30 AM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D115248: [Clang] Fix PR28101.
Mar 23 2022, 7:57 AM · Restricted Project, Restricted Project

Mar 22 2022

rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

Diagnose "same name as its class" before setting the declarator invalid as otherwise it would not be diagnosed. This also aligns with gcc's behavior.

Mar 22 2022, 11:02 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

Don't break template declarations.
re-clang-format

Mar 22 2022, 8:10 PM · Restricted Project, Restricted Project
rZhBoYao updated the summary of D115248: [Clang] Fix PR28101.
Mar 22 2022, 7:29 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

The previous diff was indeed very specific and doesn't handle

template <typename T>
struct A {
  A(void*) {}
  T A<T>{}; // expected-error{{member 'A' cannot have template arguments}}
};
Mar 22 2022, 6:46 PM · Restricted Project, Restricted Project

Dec 29 2021

rZhBoYao added a comment to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.

Thank you all for spending time reviewing this!

Dec 29 2021, 1:20 AM · Restricted Project
rZhBoYao committed rG633b002944b9: [lldb] Fix PR52702 by fixing bool conversion of Mangled (authored by rZhBoYao).
[lldb] Fix PR52702 by fixing bool conversion of Mangled
Dec 29 2021, 1:19 AM
rZhBoYao closed D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 29 2021, 1:19 AM · Restricted Project

Dec 28 2021

rZhBoYao updated the diff for D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 28 2021, 7:36 AM · Restricted Project
rZhBoYao added inline comments to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 28 2021, 6:57 AM · Restricted Project

Dec 26 2021

rZhBoYao added inline comments to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 9:30 PM · Restricted Project
rZhBoYao updated the diff for D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 9:27 PM · Restricted Project
rZhBoYao updated the diff for D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 9:09 PM · Restricted Project
rZhBoYao added inline comments to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 8:10 PM · Restricted Project

Dec 23 2021

rZhBoYao requested review of D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 23 2021, 4:32 AM · Restricted Project
rZhBoYao added a comment to D106837: Create synthetic symbol names on demand to improve memory consumption and startup times..

Hi all, I found this patch causing PR52702 in that the parent of this commit and LLDB 12 worked fine.
When disassembling a hello world C program on Linux, LLDB used to show
callq 0x401030 ; symbol stub for: puts
instead of
callq 0x401030 ; symbol stub for: ___lldb_unnamed_symbol36.
Examining the symbol table by running lldb -b -o 'image dump symtab' a.out used to show:

[   18]     20   X Undefined       0x0000000000000000                    0x0000000000000000 0x00000012 puts@GLIBC_2.2.5
                         ........
[   33]     35   X Code            0x0000000000401000                    0x000000000000001b 0x00000212 _init
[   34]     36  S  Trampoline      0x0000000000401030                    0x0000000000000010 0x00000000 puts
[   35]     37  SX Code            0x0000000000401020                    0x0000000000000010 0x00000000 ___lldb_unnamed_symbol1$$a.out

and now (ToT and LLDB 13) it's:

[   18]     20   X Undefined       0x0000000000000000                    0x0000000000000000 0x00000012 puts@GLIBC_2.2.5
                         ........
[   33]     35   X Code            0x0000000000401000                    0x000000000000001b 0x00000212 _init
[   34]     36  S  Trampoline      0x0000000000401030                    0x0000000000000010 0x00000000 ___lldb_unnamed_symbol36
[   35]     37  SX Code            0x0000000000401020                    0x0000000000000010 0x00000000 ___lldb_unnamed_symbol37

image dump symtab libc.so.6 gives similar result.
Before ec1a4917 :

[ 2366]   2367  S  Trampoline      0x0000000000025010 0x00007ffff7df2010 0x0000000000000010 0x00000000 realloc
[ 2367]   2368  S  Trampoline      0x0000000000025020 0x00007ffff7df2020 0x0000000000000010 0x00000000 __tls_get_addr
[ 2368]   2369  S  Trampoline      0x0000000000025030 0x00007ffff7df2030 0x0000000000000010 0x00000000 memalign
[ 2369]   2370  S  Trampoline      0x0000000000025040 0x00007ffff7df2040 0x0000000000000010 0x00000000 _dl_exception_create
[ 2370]   2371  S  Trampoline      0x0000000000025050 0x00007ffff7df2050 0x0000000000000010 0x00000000 __tunable_get_val
[ 2371]   2372  S  Trampoline      0x0000000000025060 0x00007ffff7df2060 0x0000000000000010 0x00000000 _dl_find_dso_for_object
[ 2372]   2373  S  Trampoline      0x0000000000025070 0x00007ffff7df2070 0x0000000000000010 0x00000000 calloc
[ 2373]   2373  SX Code            0x0000000000025000 0x00007ffff7df2000 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol1$$libc.so.6
[ 2374]   2373  SX Code            0x0000000000025300 0x00007ffff7df2300 0x0000000000000040 0x00000000 ___lldb_unnamed_symbol2$$libc.so.6
[ 2375]   2373  SX Code            0x0000000000025340 0x00007ffff7df2340 0x00000000000002f0 0x00000000 ___lldb_unnamed_symbol3$$libc.so.6
[ 2376]   2373  SX Code            0x0000000000025630 0x00007ffff7df2630 0x000000000000000c 0x00000000 ___lldb_unnamed_symbol4$$libc.so.6

After:

[ 2366]   2367  S  Trampoline      0x0000000000025010 0x00007ffff7df2010 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2367
[ 2367]   2368  S  Trampoline      0x0000000000025020 0x00007ffff7df2020 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2368
[ 2368]   2369  S  Trampoline      0x0000000000025030 0x00007ffff7df2030 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2369
[ 2369]   2370  S  Trampoline      0x0000000000025040 0x00007ffff7df2040 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2370
[ 2370]   2371  S  Trampoline      0x0000000000025050 0x00007ffff7df2050 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2371
[ 2371]   2372  S  Trampoline      0x0000000000025060 0x00007ffff7df2060 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2372
[ 2372]   2373  S  Trampoline      0x0000000000025070 0x00007ffff7df2070 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2373
[ 2373]   2374  SX Code            0x0000000000025000 0x00007ffff7df2000 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2374
[ 2374]   2375  SX Code            0x0000000000025300 0x00007ffff7df2300 0x0000000000000040 0x00000000 ___lldb_unnamed_symbol2375
[ 2375]   2376  SX Code            0x0000000000025340 0x00007ffff7df2340 0x00000000000002f0 0x00000000 ___lldb_unnamed_symbol2376
[ 2376]   2377  SX Code            0x0000000000025630 0x00007ffff7df2630 0x000000000000000c 0x00000000 ___lldb_unnamed_symbol2377

Is this intended for the performance boost? It seems to me that "S Trampoline" symbols should be handled differently.

Dec 23 2021, 12:21 AM · Restricted Project

Dec 16 2021

rZhBoYao added a comment to D115535: [libunwind] Provide a way to conveniently install libunwind headers.

Can you commit this for me? My name and email: PoYao Chang <rZhBoYao@gmail.com>.
And thank you for your time!

Dec 16 2021, 10:27 AM · Restricted Project, Restricted Project

Dec 15 2021

rZhBoYao updated the diff for D115535: [libunwind] Provide a way to conveniently install libunwind headers.

Address inline comment.

Dec 15 2021, 3:06 PM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D115535: [libunwind] Provide a way to conveniently install libunwind headers.
Dec 15 2021, 12:21 PM · Restricted Project, Restricted Project

Dec 14 2021

rZhBoYao added inline comments to D115535: [libunwind] Provide a way to conveniently install libunwind headers.
Dec 14 2021, 2:51 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115535: [libunwind] Provide a way to conveniently install libunwind headers.

All points addressed. I also updated the summary accordingly. Tested on macOS 12.1 and Ubuntu 20.04.2 LTS.

Dec 14 2021, 2:43 AM · Restricted Project, Restricted Project

Dec 10 2021

rZhBoYao requested review of D115535: [libunwind] Provide a way to conveniently install libunwind headers.
Dec 10 2021, 9:14 AM · Restricted Project, Restricted Project

Dec 9 2021

rZhBoYao retitled D115248: [Clang] Fix PR28101 from [clang] Fix Bug 28101 to [clang] Fix PR28101.
Dec 9 2021, 9:08 AM · Restricted Project, Restricted Project

Dec 8 2021

rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

I added a test. There were 17 module and PCH related failed tests on my local machine; however, when I ran the test on then ToT the same 17 tests failed, but on GitHub it does show 2 successful checks. So maybe it's something else.

Dec 8 2021, 7:42 AM · Restricted Project, Restricted Project

Dec 7 2021

rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.
Dec 7 2021, 7:40 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D115248: [Clang] Fix PR28101.
Dec 7 2021, 6:11 AM · Restricted Project, Restricted Project
rZhBoYao updated rZhBoYao.
Dec 7 2021, 4:57 AM

Apr 6 2020

rZhBoYao added a comment to D77532: Fix a typo in clang/lib/Frontend/FrontendAction.cpp.

LGTM! Do you need someone to commit on your behalf?

Apr 6 2020, 5:54 AM · Restricted Project
rZhBoYao updated the diff for D77532: Fix a typo in clang/lib/Frontend/FrontendAction.cpp.

revert the change to trailing newlines

Apr 6 2020, 2:08 AM · Restricted Project
rZhBoYao created D77532: Fix a typo in clang/lib/Frontend/FrontendAction.cpp.
Apr 6 2020, 2:08 AM · Restricted Project