Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

rZhBoYao (PoYao Chang)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2020, 12:32 AM (180 w, 5 d)

Recent Activity

Aug 22 2023

rZhBoYao added a comment to D158372: [Clang] Treat invalid UDL as two tokens.

OK, will do it by the end of this week.

Aug 22 2023, 10:31 AM · Restricted Project, Restricted Project

Aug 21 2023

rZhBoYao added inline comments to D158372: [Clang] Treat invalid UDL as two tokens.
Aug 21 2023, 9:44 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D158372: [Clang] Treat invalid UDL as two tokens.
Aug 21 2023, 9:43 AM · Restricted Project, Restricted Project

Aug 20 2023

rZhBoYao added a comment to D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

D158372 addresses comments.

Aug 20 2023, 11:28 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D158372: [Clang] Treat invalid UDL as two tokens.
Aug 20 2023, 11:26 AM · Restricted Project, Restricted Project

Aug 18 2023

rZhBoYao added a comment to D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

I’ll see what I can do regarding reviving the string concat behavior. It feels like that a more refined treatment than before can be achieved. Maybe adds an imaginary preceding whitespace only when we can find a macro with the same name.

Aug 18 2023, 12:24 PM · Restricted Project, Restricted Project
rZhBoYao added a comment to D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

If proper spec-conformance means we can no longer support the ability to allow such out-of-spec pre-c++11 code to work anymore, that's probably OK...but, in that case, we also need to eliminate the warning option, and mention the change in the release notes.

Works in C++98 mode tho. TIL people exploit this to mix pre-C++11 code into modern C++. I agree that a reminder for those people in the release note is needed.

And, if that _was_ an intended change, then we have other diagnostics which need to be fixed up now

Agreed

Aug 18 2023, 10:47 AM · Restricted Project, Restricted Project
rZhBoYao added a comment to D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

Unfortunately the option -Wno-reserved-user-defined-literal fails after this:

#define MYTHING "_something_"

const char* f() {
  return "ONE"MYTHING"TWO";
}
$ clang -Wno-reserved-user-defined-literal repro.cxx
repro.cxx:4:15: error: no matching literal operator for call to 'operator""MYTHING' with arguments of types 'const char *' and 'unsigned long', and no matching literal operator template
    4 |   return "ONE"MYTHING"TWO";
      |               ^
1 error generated.
Aug 18 2023, 7:42 AM · Restricted Project, Restricted Project

Aug 17 2023

rZhBoYao committed rGf2583f3acf59: [Clang] CWG1473: do not err on the lack of space after operator"" (authored by rZhBoYao).
[Clang] CWG1473: do not err on the lack of space after operator""
Aug 17 2023, 8:12 AM · Restricted Project, Restricted Project
rZhBoYao closed D153156: [Clang] CWG1473: do not err on the lack of space after operator"".
Aug 17 2023, 8:12 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

Thank Aaron and Vlad for reviewing this! Just updating the diff to reflect the final version.

Aug 17 2023, 8:08 AM · Restricted Project, Restricted Project

Aug 11 2023

rZhBoYao added inline comments to D155081: Specify the developer policy around links to external resources.
Aug 11 2023, 7:55 AM · Restricted Project, Restricted Project

Jul 24 2023

rZhBoYao added a comment to D156063: [Clang] Reject programs declaring namespace std to be inline.

Thanks for all the suggestions and review comments!

Jul 24 2023, 10:43 AM · Restricted Project, Restricted Project
rZhBoYao committed rGbed75faf7d76: [Clang] Reject programs declaring namespace std to be inline (authored by rZhBoYao).
[Clang] Reject programs declaring namespace std to be inline
Jul 24 2023, 10:32 AM · Restricted Project, Restricted Project
rZhBoYao closed D156063: [Clang] Reject programs declaring namespace std to be inline.
Jul 24 2023, 10:31 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses.

Refactor VisitCXXOperatorCallExpr and mark CWG2571 as done in Clang 15 (deliberately the same version P2128R6 was implemented) since this patch only fix the diagnostics around it.

Jul 24 2023, 8:12 AM · Restricted Project, Restricted Project
rZhBoYao added a comment to D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses.

Thanks for the reminder. I am aware of that. Browsing through 762672a73a1e and a560ccf2af7a, I believe the indeterminately sequenced requirement is met, neither of which test the codegen so I might just put the example shown in the release note in dr25xx.cpp.

Jul 24 2023, 6:56 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D156063: [Clang] Reject programs declaring namespace std to be inline.

Addressed comments

Jul 24 2023, 6:28 AM · Restricted Project, Restricted Project
rZhBoYao updated subscribers of D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses.

BTW, I am not sure if CWG2571 is implemented by @cor3ntin? If so, can we mark it as done on https://clang.llvm.org/cxx_dr_status.html#2571? This patch handles the warning around it tho.

Jul 24 2023, 5:46 AM · Restricted Project, Restricted Project

Jul 23 2023

rZhBoYao updated the summary of D156063: [Clang] Reject programs declaring namespace std to be inline.
Jul 23 2023, 11:33 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses.

Improve the test.

Jul 23 2023, 11:31 AM · Restricted Project, Restricted Project
rZhBoYao added a comment to D156063: [Clang] Reject programs declaring namespace std to be inline.

https://eel.is/c++draft/namespace.std#7 is in the library clause.
Couldn't find a better place to put the test other than clang/test/CXX/dcl.dcl/basic.namespace/namespace.def/p7.cpp which is for https://eel.is/c++draft/namespace.def.general#4.sentence-2.

Jul 23 2023, 11:01 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D156063: [Clang] Reject programs declaring namespace std to be inline.
Jul 23 2023, 10:57 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses.

Put -Windeterminately-sequenced under -Wsequence-point's control

Jul 23 2023, 9:54 AM · Restricted Project, Restricted Project
rZhBoYao updated the summary of D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses.
Jul 23 2023, 8:31 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses.
Jul 23 2023, 8:29 AM · Restricted Project, Restricted Project

Jul 20 2023

rZhBoYao added a comment to D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

Gentle ping :)

Jul 20 2023, 9:49 AM · Restricted Project, Restricted Project

Jul 18 2023

rZhBoYao committed rG5ce5e983f82c: [Clang] Add warnings for CWG2521 (authored by rZhBoYao).
[Clang] Add warnings for CWG2521
Jul 18 2023, 4:24 PM · Restricted Project, Restricted Project
rZhBoYao closed D152632: [Clang] Add warnings for CWG2521.
Jul 18 2023, 4:24 PM · Restricted Project, Restricted Project

Jul 17 2023

rZhBoYao added a comment to D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

There seems to be no clear objection to this and https://reviews.llvm.org/D152632 and the CI are passing for both. Any chance that I merge these two before llvm 17 branch out (IIRC the next Monday)?

Jul 17 2023, 12:15 PM · Restricted Project, Restricted Project
rZhBoYao added a reviewer for D153156: [Clang] CWG1473: do not err on the lack of space after operator"": Restricted Project.
Jul 17 2023, 11:24 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate.
Jul 17 2023, 11:17 AM · Restricted Project, Restricted Project
rZhBoYao added a reviewer for D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate: Restricted Project.
Jul 17 2023, 8:41 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate.
Jul 17 2023, 8:41 AM · Restricted Project, Restricted Project

Jul 14 2023

rZhBoYao added a comment to D152632: [Clang] Add warnings for CWG2521.

Hmm… I don’t see why check-format keeps failing. I git clang-format thrice before uploading.
https://buildkite.com/llvm-project/premerge-checks/builds/164452

Jul 14 2023, 6:44 AM · Restricted Project, Restricted Project

Jul 13 2023

rZhBoYao committed rGbd03e0ca7572: [libc++][NFC] Suppress -Wdeprecated-literal-operator (authored by rZhBoYao).
[libc++][NFC] Suppress -Wdeprecated-literal-operator
Jul 13 2023, 3:53 PM · Restricted Project, Restricted Project
rZhBoYao closed D155200: [libc++][NFC] Suppress -Wdeprecated-literal-operator.
Jul 13 2023, 3:53 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D153156: [Clang] CWG1473: do not err on the lack of space after operator"".
Jul 13 2023, 10:40 AM · Restricted Project, Restricted Project
rZhBoYao added a comment to D155200: [libc++][NFC] Suppress -Wdeprecated-literal-operator.

co_awaiting https://reviews.llvm.org/D152632 to pass CI to see if this patch fixes the issues...

Jul 13 2023, 9:39 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D152632: [Clang] Add warnings for CWG2521.

-Wdeprecated-literal-operator will be on by default in https://reviews.llvm.org/D153156
This one is now blocked by the libc++ fix: https://reviews.llvm.org/D155200

Jul 13 2023, 9:30 AM · Restricted Project, Restricted Project
rZhBoYao retitled D155200: [libc++][NFC] Suppress -Wdeprecated-literal-operator from [libc++][NFC] Suppress deprecation warning introduced by D152632 to [libc++][NFC] Suppress -Wdeprecated-literal-operator.
Jul 13 2023, 6:49 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D155200: [libc++][NFC] Suppress -Wdeprecated-literal-operator.
Jul 13 2023, 6:49 AM · Restricted Project, Restricted Project

Jul 10 2023

rZhBoYao updated the diff for D153156: [Clang] CWG1473: do not err on the lack of space after operator"".
Jul 10 2023, 9:52 AM · Restricted Project, Restricted Project
rZhBoYao added a comment to D152632: [Clang] Add warnings for CWG2521.

I am wondering why we don't fold this into -Wreserved-identifier

Jul 10 2023, 9:43 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

Reverse the dependency chain.

Jul 10 2023, 9:14 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D152632: [Clang] Add warnings for CWG2521.

Defaults to on for C++23 only. Enable for all the language modes in another patch.

Jul 10 2023, 9:06 AM · Restricted Project, Restricted Project

Jun 16 2023

rZhBoYao updated the diff for D152632: [Clang] Add warnings for CWG2521.

Depends on D153156

Jun 16 2023, 10:49 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D153156: [Clang] CWG1473: do not err on the lack of space after operator"".
Jun 16 2023, 10:43 AM · Restricted Project, Restricted Project

Jun 14 2023

rZhBoYao added a comment to D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit.

Looks like this breaks check-clang on Mac: http://45.33.8.238/macm1/62779/step_7.txt

Jun 14 2023, 10:07 AM · Restricted Project, Restricted Project, Restricted Project

Jun 13 2023

rZhBoYao added inline comments to D152632: [Clang] Add warnings for CWG2521.
Jun 13 2023, 9:58 AM · Restricted Project, Restricted Project

Jun 11 2023

rZhBoYao updated the diff for D152632: [Clang] Add warnings for CWG2521.

Overhaul for dr25xx.cpp.

Jun 11 2023, 9:13 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D152632: [Clang] Add warnings for CWG2521.

Addressed comments.
Thanks for letting me know how to structure tests for DRs.

Jun 11 2023, 3:40 AM · Restricted Project, Restricted Project

Jun 10 2023

rZhBoYao added a reviewer for D152632: [Clang] Add warnings for CWG2521: Restricted Project.

Few questions:
I think this applies to all the language modes?
Somehow, https://wg21.link/CWG2521 is not redirecting to https://cplusplus.github.io/CWG/issues/2521.html. Is this normal?

Jun 10 2023, 2:18 PM · Restricted Project, Restricted Project
rZhBoYao requested review of D152632: [Clang] Add warnings for CWG2521.
Jun 10 2023, 2:13 PM · Restricted Project, Restricted Project

May 15 2023

rZhBoYao abandoned D139586: [Clang][C++23] Lifetime extension in range-based for loops.

@rZhBoYao are you still working on this? Thanks!

May 15 2023, 9:48 AM · Restricted Project, Restricted Project

Dec 9 2022

rZhBoYao added a reviewer for D139586: [Clang][C++23] Lifetime extension in range-based for loops: erichkeane.
Dec 9 2022, 3:31 AM · Restricted Project, Restricted Project

Dec 7 2022

rZhBoYao added a comment to D139586: [Clang][C++23] Lifetime extension in range-based for loops.

Consider:

struct T {
  const int *begin() const;
  const int *end()   const;
  T &r() [[clang::lifetimebound]];
  T t();
};
Dec 7 2022, 3:11 PM · Restricted Project, Restricted Project
rZhBoYao requested review of D139586: [Clang][C++23] Lifetime extension in range-based for loops.
Dec 7 2022, 2:54 PM · Restricted Project, Restricted Project

Apr 11 2022

rZhBoYao committed rG50b1faf5c188: [Clang] CWG 1394: Incomplete types as parameters of deleted functions (authored by rZhBoYao).
[Clang] CWG 1394: Incomplete types as parameters of deleted functions
Apr 11 2022, 8:18 PM · Restricted Project, Restricted Project
rZhBoYao committed rG369c5fa17be0: [NFC][Clang] Use previously declared variable instead of calling function… (authored by rZhBoYao).
[NFC][Clang] Use previously declared variable instead of calling function…
Apr 11 2022, 8:18 PM · Restricted Project, Restricted Project
rZhBoYao closed D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 11 2022, 8:18 PM · Restricted Project, Restricted Project

Apr 8 2022

rZhBoYao added a comment to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Revisiting @ChuanqiXu 's code suggestion...

Apr 8 2022, 2:21 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Reordered enumerators.

Apr 8 2022, 10:59 AM · Restricted Project, Restricted Project

Apr 7 2022

rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 10:54 PM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 10:28 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Added release note.

Apr 7 2022, 3:02 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Updating the status of CWG 1394 is the only change.

Apr 7 2022, 2:33 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Removed member function test cases and addressed comments,
which includes:

  1. Sema::SetFunctionBodyKind
  2. Change enum names
  3. Be clear about delete being C++ specific.
Apr 7 2022, 1:31 PM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 11:46 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

Handling of eagerly parsed deleted or defaulted function must happen AFTER D.complete(Res);.

Apr 7 2022, 11:44 AM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 11:41 AM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 7 2022, 11:15 AM · Restricted Project, Restricted Project

Apr 6 2022

rZhBoYao updated the diff for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

I think an extra parameter is inevitable without complicating things too much.

Apr 6 2022, 3:28 AM · Restricted Project, Restricted Project

Apr 5 2022

rZhBoYao added inline comments to D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 5 2022, 8:14 PM · Restricted Project, Restricted Project

Apr 2 2022

rZhBoYao updated the summary of D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 2 2022, 6:15 PM · Restricted Project, Restricted Project
rZhBoYao added a reviewer for D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions: rtrieu.
Apr 2 2022, 10:41 AM · Restricted Project, Restricted Project
rZhBoYao requested review of D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.
Apr 2 2022, 9:11 AM · Restricted Project, Restricted Project

Mar 23 2022

rZhBoYao committed rG355f1c75aa66: [Clang] Fix PR28101 (authored by rZhBoYao).
[Clang] Fix PR28101
Mar 23 2022, 9:39 AM · Restricted Project
rZhBoYao closed D115248: [Clang] Fix PR28101.
Mar 23 2022, 9:39 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

Added an entry in release notes. Waiting for CI...

Mar 23 2022, 9:05 AM · Restricted Project, Restricted Project
rZhBoYao added a comment to D115248: [Clang] Fix PR28101.

By 'release notes' do you mean a more detailed commit message?

Mar 23 2022, 8:37 AM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

This passes check-clang-semacxx on my machine.

Mar 23 2022, 8:30 AM · Restricted Project, Restricted Project
rZhBoYao added inline comments to D115248: [Clang] Fix PR28101.
Mar 23 2022, 7:57 AM · Restricted Project, Restricted Project

Mar 22 2022

rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

Diagnose "same name as its class" before setting the declarator invalid as otherwise it would not be diagnosed. This also aligns with gcc's behavior.

Mar 22 2022, 11:02 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

Don't break template declarations.
re-clang-format

Mar 22 2022, 8:10 PM · Restricted Project, Restricted Project
rZhBoYao updated the summary of D115248: [Clang] Fix PR28101.
Mar 22 2022, 7:29 PM · Restricted Project, Restricted Project
rZhBoYao updated the diff for D115248: [Clang] Fix PR28101.

The previous diff was indeed very specific and doesn't handle

template <typename T>
struct A {
  A(void*) {}
  T A<T>{}; // expected-error{{member 'A' cannot have template arguments}}
};
Mar 22 2022, 6:46 PM · Restricted Project, Restricted Project

Dec 29 2021

rZhBoYao added a comment to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.

Thank you all for spending time reviewing this!

Dec 29 2021, 1:20 AM · Restricted Project
rZhBoYao committed rG633b002944b9: [lldb] Fix PR52702 by fixing bool conversion of Mangled (authored by rZhBoYao).
[lldb] Fix PR52702 by fixing bool conversion of Mangled
Dec 29 2021, 1:19 AM
rZhBoYao closed D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 29 2021, 1:19 AM · Restricted Project

Dec 28 2021

rZhBoYao updated the diff for D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 28 2021, 7:36 AM · Restricted Project
rZhBoYao added inline comments to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 28 2021, 6:57 AM · Restricted Project

Dec 26 2021

rZhBoYao added inline comments to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 9:30 PM · Restricted Project
rZhBoYao updated the diff for D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 9:27 PM · Restricted Project
rZhBoYao updated the diff for D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 9:09 PM · Restricted Project
rZhBoYao added inline comments to D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 26 2021, 8:10 PM · Restricted Project

Dec 23 2021

rZhBoYao requested review of D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled.
Dec 23 2021, 4:32 AM · Restricted Project
rZhBoYao added a comment to D106837: Create synthetic symbol names on demand to improve memory consumption and startup times..

Hi all, I found this patch causing PR52702 in that the parent of this commit and LLDB 12 worked fine.
When disassembling a hello world C program on Linux, LLDB used to show
callq 0x401030 ; symbol stub for: puts
instead of
callq 0x401030 ; symbol stub for: ___lldb_unnamed_symbol36.
Examining the symbol table by running lldb -b -o 'image dump symtab' a.out used to show:

[   18]     20   X Undefined       0x0000000000000000                    0x0000000000000000 0x00000012 puts@GLIBC_2.2.5
                         ........
[   33]     35   X Code            0x0000000000401000                    0x000000000000001b 0x00000212 _init
[   34]     36  S  Trampoline      0x0000000000401030                    0x0000000000000010 0x00000000 puts
[   35]     37  SX Code            0x0000000000401020                    0x0000000000000010 0x00000000 ___lldb_unnamed_symbol1$$a.out

and now (ToT and LLDB 13) it's:

[   18]     20   X Undefined       0x0000000000000000                    0x0000000000000000 0x00000012 puts@GLIBC_2.2.5
                         ........
[   33]     35   X Code            0x0000000000401000                    0x000000000000001b 0x00000212 _init
[   34]     36  S  Trampoline      0x0000000000401030                    0x0000000000000010 0x00000000 ___lldb_unnamed_symbol36
[   35]     37  SX Code            0x0000000000401020                    0x0000000000000010 0x00000000 ___lldb_unnamed_symbol37

image dump symtab libc.so.6 gives similar result.
Before ec1a4917 :

[ 2366]   2367  S  Trampoline      0x0000000000025010 0x00007ffff7df2010 0x0000000000000010 0x00000000 realloc
[ 2367]   2368  S  Trampoline      0x0000000000025020 0x00007ffff7df2020 0x0000000000000010 0x00000000 __tls_get_addr
[ 2368]   2369  S  Trampoline      0x0000000000025030 0x00007ffff7df2030 0x0000000000000010 0x00000000 memalign
[ 2369]   2370  S  Trampoline      0x0000000000025040 0x00007ffff7df2040 0x0000000000000010 0x00000000 _dl_exception_create
[ 2370]   2371  S  Trampoline      0x0000000000025050 0x00007ffff7df2050 0x0000000000000010 0x00000000 __tunable_get_val
[ 2371]   2372  S  Trampoline      0x0000000000025060 0x00007ffff7df2060 0x0000000000000010 0x00000000 _dl_find_dso_for_object
[ 2372]   2373  S  Trampoline      0x0000000000025070 0x00007ffff7df2070 0x0000000000000010 0x00000000 calloc
[ 2373]   2373  SX Code            0x0000000000025000 0x00007ffff7df2000 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol1$$libc.so.6
[ 2374]   2373  SX Code            0x0000000000025300 0x00007ffff7df2300 0x0000000000000040 0x00000000 ___lldb_unnamed_symbol2$$libc.so.6
[ 2375]   2373  SX Code            0x0000000000025340 0x00007ffff7df2340 0x00000000000002f0 0x00000000 ___lldb_unnamed_symbol3$$libc.so.6
[ 2376]   2373  SX Code            0x0000000000025630 0x00007ffff7df2630 0x000000000000000c 0x00000000 ___lldb_unnamed_symbol4$$libc.so.6

After:

[ 2366]   2367  S  Trampoline      0x0000000000025010 0x00007ffff7df2010 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2367
[ 2367]   2368  S  Trampoline      0x0000000000025020 0x00007ffff7df2020 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2368
[ 2368]   2369  S  Trampoline      0x0000000000025030 0x00007ffff7df2030 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2369
[ 2369]   2370  S  Trampoline      0x0000000000025040 0x00007ffff7df2040 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2370
[ 2370]   2371  S  Trampoline      0x0000000000025050 0x00007ffff7df2050 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2371
[ 2371]   2372  S  Trampoline      0x0000000000025060 0x00007ffff7df2060 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2372
[ 2372]   2373  S  Trampoline      0x0000000000025070 0x00007ffff7df2070 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2373
[ 2373]   2374  SX Code            0x0000000000025000 0x00007ffff7df2000 0x0000000000000010 0x00000000 ___lldb_unnamed_symbol2374
[ 2374]   2375  SX Code            0x0000000000025300 0x00007ffff7df2300 0x0000000000000040 0x00000000 ___lldb_unnamed_symbol2375
[ 2375]   2376  SX Code            0x0000000000025340 0x00007ffff7df2340 0x00000000000002f0 0x00000000 ___lldb_unnamed_symbol2376
[ 2376]   2377  SX Code            0x0000000000025630 0x00007ffff7df2630 0x000000000000000c 0x00000000 ___lldb_unnamed_symbol2377

Is this intended for the performance boost? It seems to me that "S Trampoline" symbols should be handled differently.

Dec 23 2021, 12:21 AM · Restricted Project

Dec 16 2021

rZhBoYao added a comment to D115535: [libunwind] Provide a way to conveniently install libunwind headers.

Can you commit this for me? My name and email: PoYao Chang <rZhBoYao@gmail.com>.
And thank you for your time!

Dec 16 2021, 10:27 AM · Restricted Project, Restricted Project

Dec 15 2021

rZhBoYao updated the diff for D115535: [libunwind] Provide a way to conveniently install libunwind headers.

Address inline comment.

Dec 15 2021, 3:06 PM · Restricted Project, Restricted Project