harlanhaskins (Harlan Haskins)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2016, 1:16 PM (82 w, 5 d)

Recent Activity

Sat, Sep 30

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Address comments
  • uint64_t -> size_t for string lengths
  • Add simple debuginfo tests
  • Fix unused variable warning
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
  • Add test and update CMakeLists to build debuginfo.c
  • Fix test
  • Use unsigned instead of explicitly sized unsigned integer types
  • Add comment explaining 0 for debug locations
  • Expand enum definitions and translate to DI (#1)
Sat, Sep 30, 3:12 PM

Jun 22 2017

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Add comment explaining 0 for debug locations
Jun 22 2017, 3:45 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 22 2017, 2:52 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 22 2017, 10:26 AM

Jun 21 2017

harlanhaskins updated the summary of D32368: LLVM C DIBuilder Creation APIs.
Jun 21 2017, 10:30 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 21 2017, 10:25 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Address comments
  • uint64_t -> size_t for string lengths
  • Add simple debuginfo tests
  • Fix unused variable warning
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
  • Add test and update CMakeLists to build debuginfo.c
  • Fix test
  • Use unsigned instead of explicitly sized unsigned integer types
Jun 21 2017, 9:29 PM

Jun 3 2017

harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 3 2017, 1:56 PM

Jun 2 2017

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Address comments
  • uint64_t -> size_t for string lengths
  • Add simple debuginfo tests
  • Fix unused variable warning
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
  • Add test and update CMakeLists to build debuginfo.c
Jun 2 2017, 9:19 PM

May 20 2017

harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
May 20 2017, 11:52 AM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
May 20 2017, 11:51 AM

May 19 2017

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix unused variable warning
May 19 2017, 12:14 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Add simple debuginfo tests
May 19 2017, 12:13 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • uint64_t -> size_t for string lengths
May 19 2017, 11:13 AM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Address comments
May 19 2017, 10:55 AM

Apr 22 2017

harlanhaskins added inline comments to D32152: Expose NoReturn attribute to libclang.
Apr 22 2017, 5:15 PM · Restricted Project

Apr 21 2017

harlanhaskins retitled D32152: Expose NoReturn attribute to libclang from Add clang_Cursor_isFunctionNoReturn to libclang to Expose NoReturn attribute to libclang.
Apr 21 2017, 1:44 PM · Restricted Project
harlanhaskins updated the diff for D32152: Expose NoReturn attribute to libclang.
  • Change noreturn interface to expose NoReturn as an attribute
Apr 21 2017, 1:43 PM · Restricted Project
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Apr 21 2017, 1:21 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Apr 21 2017, 1:17 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Pass string parameters as pointer/length pairs
Apr 21 2017, 1:00 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Apr 21 2017, 12:51 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.

Add back remanining files (sorry for the email spam!)

Apr 21 2017, 12:46 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.

Fix 80-column limit for LLVMDWARFSourceLanguage

Apr 21 2017, 12:45 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.

Fix merge head

Apr 21 2017, 12:43 PM
harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.

arc...picked some wrong branches here. I'll fix this diff 😅

Apr 21 2017, 12:41 PM
harlanhaskins created D32368: LLVM C DIBuilder Creation APIs.
Apr 21 2017, 12:40 PM

Apr 20 2017

harlanhaskins added inline comments to D32152: Expose NoReturn attribute to libclang.
Apr 20 2017, 11:16 AM · Restricted Project
harlanhaskins added a comment to D32152: Expose NoReturn attribute to libclang.

This fails to link when I compile it locally, and I have absolutely no idea why. So this is still untested.

Apr 20 2017, 10:00 AM · Restricted Project
harlanhaskins updated the diff for D32152: Expose NoReturn attribute to libclang.

Add test for clang_Cursor_isFunctionNoReturn

Apr 20 2017, 9:57 AM · Restricted Project
harlanhaskins added a comment to D32122: Introduce LLVMDIBuilderRef.

I do not have commit rights. If you could merge, that'd be great. Then I'll submit the first subset of DIBuilder APIs!

Apr 20 2017, 6:42 AM

Apr 19 2017

harlanhaskins added inline comments to D32122: Introduce LLVMDIBuilderRef.
Apr 19 2017, 6:06 PM
harlanhaskins updated the diff for D32122: Introduce LLVMDIBuilderRef.
  • Fix typo
Apr 19 2017, 6:06 PM
harlanhaskins added a comment to D32122: Introduce LLVMDIBuilderRef.

@echristo, @whitequark, @aprantl Are we good to merge this?

Apr 19 2017, 1:49 PM

Apr 18 2017

harlanhaskins updated the diff for D32122: Introduce LLVMDIBuilderRef.

Simplifies the patch to just define LLVMDIBuilderRef

Apr 18 2017, 1:32 PM
harlanhaskins retitled D32122: Introduce LLVMDIBuilderRef from DIBuilder C API to Introduce LLVMDIBuilderRef.
Apr 18 2017, 1:28 PM
harlanhaskins added a comment to D32122: Introduce LLVMDIBuilderRef.

I seem to have messed up this patch.

Apr 18 2017, 1:24 PM
harlanhaskins added inline comments to D32122: Introduce LLVMDIBuilderRef.
Apr 18 2017, 1:19 PM
harlanhaskins added a reviewer for D32152: Expose NoReturn attribute to libclang: dblaikie.
Apr 18 2017, 10:52 AM · Restricted Project
harlanhaskins added a reviewer for D32152: Expose NoReturn attribute to libclang: akyrtzi.
Apr 18 2017, 10:43 AM · Restricted Project

Apr 17 2017

harlanhaskins created D32152: Expose NoReturn attribute to libclang.
Apr 17 2017, 8:48 PM · Restricted Project
harlanhaskins updated subscribers of D32122: Introduce LLVMDIBuilderRef.

I talked with @CodaFi about this API; he's been modeling the wrapper for LLVMSwift based on this initial review just to get a feel for the API.

Apr 17 2017, 8:14 PM
harlanhaskins added a comment to D32122: Introduce LLVMDIBuilderRef.

There are a lot of binding out there that we just aren't aware of. And getting failure at runtime because the expected arguments to a function do not match anymore is seriously not funny to debug.

Apr 17 2017, 10:38 AM
harlanhaskins updated the diff for D32122: Introduce LLVMDIBuilderRef.

Update the definitions for LLVMDIBuilderRef and LLVMMetadataRef to be more in line with how the rest of the opaque types are declared.

Apr 17 2017, 10:36 AM
harlanhaskins added a comment to D32122: Introduce LLVMDIBuilderRef.

That said, would random changes to this API be upsetting Harlan? :)

Apr 17 2017, 10:06 AM

Apr 16 2017

harlanhaskins created D32122: Introduce LLVMDIBuilderRef.
Apr 16 2017, 8:52 PM

Jul 17 2016

harlanhaskins added inline comments to D18278: llvm-cov HTML Generation.
Jul 17 2016, 2:03 PM

Jul 1 2016

harlanhaskins added a comment to D18278: llvm-cov HTML Generation.

I don't think that's correct.

Jul 1 2016, 11:26 AM

Jun 30 2016

harlanhaskins added a comment to D18278: llvm-cov HTML Generation.

Sorry, I should've provided more details. I ran llvm-cov with -output-dir swift-coverage, which output everything, including the index file, into swift-coverage.

Jun 30 2016, 9:11 AM

Jun 29 2016

harlanhaskins added a comment to D18278: llvm-cov HTML Generation.

I just ran this on an instrumented Swift code run, and it worked really great! One issue, though; the coverage was output to /home/harlan/swift-coverage, but the hyperlinks pointed to swift-coverage/..., meaning that all the hyperlinks were relative to the parent of the index file.

Jun 29 2016, 6:53 PM
harlanhaskins requested changes to D18278: llvm-cov HTML Generation.

Looking at the bitcode compatibility coverage example, it looks like those hyperlinks in the index page are absolute links to /tmp/llvm-as.dir/coverage/<file>

Jun 29 2016, 2:31 PM
harlanhaskins accepted D18278: llvm-cov HTML Generation.
Jun 29 2016, 1:47 PM
harlanhaskins added a comment to D18278: llvm-cov HTML Generation.
Jun 29 2016, 1:46 PM

May 9 2016

harlanhaskins added a comment to D18278: llvm-cov HTML Generation.

Justin's recommendations amount to a refactor of much of llvm-cov, and unfortunately I don't have the time right now to overhaul this change. I'll try to get to it soon, but things have ramped up here.

May 9 2016, 2:05 PM

Apr 9 2016

harlanhaskins added a comment to D18278: llvm-cov HTML Generation.

Any update on the patch? Justin had some made some comments ..

Apr 9 2016, 1:02 PM

Mar 24 2016

harlanhaskins updated the diff for D18278: llvm-cov HTML Generation.

Removed colon from HTML function title

Mar 24 2016, 3:59 PM
harlanhaskins updated subscribers of D18278: llvm-cov HTML Generation.
Mar 24 2016, 12:57 PM

Mar 18 2016

harlanhaskins updated the diff for D18278: llvm-cov HTML Generation.

Removed binary profdata files and updated tests

Mar 18 2016, 3:46 PM
harlanhaskins added reviewers for D18278: llvm-cov HTML Generation: bogner, vsk, MaggieYi, davidxl.
Mar 18 2016, 1:37 PM
harlanhaskins retitled D18278: llvm-cov HTML Generation from to llvm-cov HTML Generation.
Mar 18 2016, 1:35 PM