Page MenuHomePhabricator
People harlanhaskins

harlanhaskins (Harlan Haskins)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2016, 1:16 PM (328 w, 5 d)

Recent Activity
View All

Dec 12 2019

harlanhaskins committed rGc96f764005d3: [APINotes] Adopt FileManager's error-returning APIs (authored by harlanhaskins).
[APINotes] Adopt FileManager's error-returning APIs
Dec 12 2019, 2:26 PM
harlanhaskins committed rG7f90ed907518: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by harlanhaskins).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Dec 12 2019, 2:26 PM

Sep 4 2019

harlanhaskins committed rL370990: Request commit access for harlanhaskins on GitHub.
Request commit access for harlanhaskins on GitHub
Sep 4 2019, 2:51 PM

Aug 1 2019

harlanhaskins committed rGe86fffcd4489: Fix Windows branch of FileManagerTest changes (authored by harlanhaskins).
Fix Windows branch of FileManagerTest changes
Aug 1 2019, 2:59 PM
harlanhaskins committed rL367622: Fix Windows branch of FileManagerTest changes.
Fix Windows branch of FileManagerTest changes
Aug 1 2019, 2:59 PM
harlanhaskins committed rG5341f79a90bb: Fix use-after-move in ClangBasicTests (authored by harlanhaskins).
Fix use-after-move in ClangBasicTests
Aug 1 2019, 2:51 PM
harlanhaskins committed rL367620: Fix use-after-move in ClangBasicTests.
Fix use-after-move in ClangBasicTests
Aug 1 2019, 2:51 PM
harlanhaskins committed rGa02f85768d2d: [clang-tools-extra] Adopt FileManager's error-returning APIs (authored by harlanhaskins).
[clang-tools-extra] Adopt FileManager's error-returning APIs
Aug 1 2019, 2:34 PM
harlanhaskins committed rG84586c1423aa: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure (authored by harlanhaskins).
[clang] Change FileManager to use llvm::ErrorOr instead of null on failure
Aug 1 2019, 2:34 PM
harlanhaskins committed rG8d323d150610: [clang] Adopt new FileManager error-returning APIs (authored by harlanhaskins).
[clang] Adopt new FileManager error-returning APIs
Aug 1 2019, 2:34 PM
harlanhaskins committed rG461f0722dd26: [clang] Adopt llvm::ErrorOr in FileManager methods (authored by harlanhaskins).
[clang] Adopt llvm::ErrorOr in FileManager methods
Aug 1 2019, 2:34 PM
harlanhaskins committed rL367618: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
[clang] Change FileManager to use llvm::ErrorOr instead of null on failure
Aug 1 2019, 2:34 PM
harlanhaskins closed D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Aug 1 2019, 2:34 PM · Restricted Project, Restricted Project, Restricted Project
harlanhaskins committed rL367617: [clang-tools-extra] Adopt FileManager's error-returning APIs.
[clang-tools-extra] Adopt FileManager's error-returning APIs
Aug 1 2019, 2:34 PM
harlanhaskins committed rL367616: [clang] Adopt new FileManager error-returning APIs.
[clang] Adopt new FileManager error-returning APIs
Aug 1 2019, 2:34 PM
harlanhaskins committed rL367615: [clang] Adopt llvm::ErrorOr in FileManager methods.
[clang] Adopt llvm::ErrorOr in FileManager methods
Aug 1 2019, 2:33 PM
harlanhaskins added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Aug 1 2019, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
harlanhaskins updated the diff for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.

Updated in response to feedback

Aug 1 2019, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Jul 31 2019

harlanhaskins updated the diff for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.

Store references instead of raw pointers in FileManger's cache

Jul 31 2019, 4:34 PM · Restricted Project, Restricted Project, Restricted Project
harlanhaskins added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Jul 31 2019, 4:30 PM · Restricted Project, Restricted Project, Restricted Project
harlanhaskins added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Jul 31 2019, 3:43 PM · Restricted Project, Restricted Project, Restricted Project
harlanhaskins updated the summary of D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Jul 31 2019, 1:21 PM · Restricted Project, Restricted Project, Restricted Project
harlanhaskins updated the summary of D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Jul 31 2019, 1:20 PM · Restricted Project, Restricted Project, Restricted Project
harlanhaskins created D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Jul 31 2019, 1:20 PM · Restricted Project, Restricted Project, Restricted Project

May 25 2019

harlanhaskins accepted D62456: [LLVM-C] Improve Bindings to The Internalize Pass.
May 25 2019, 2:30 PM · Restricted Project

Apr 16 2019

harlanhaskins committed rGd8f776af6ed9: [FileSystemStatCache] Update test for new FileSystemStatCache API (authored by harlanhaskins).
[FileSystemStatCache] Update test for new FileSystemStatCache API
Apr 16 2019, 11:01 AM
harlanhaskins committed rL358511: [FileSystemStatCache] Update test for new FileSystemStatCache API.
[FileSystemStatCache] Update test for new FileSystemStatCache API
Apr 16 2019, 11:01 AM
harlanhaskins committed rC358511: [FileSystemStatCache] Update test for new FileSystemStatCache API.
[FileSystemStatCache] Update test for new FileSystemStatCache API
Apr 16 2019, 11:01 AM
harlanhaskins closed D60786: [FileSystemStatCache] Update test for new FileSystemStatCache API.
Apr 16 2019, 11:01 AM · Restricted Project
harlanhaskins created D60786: [FileSystemStatCache] Update test for new FileSystemStatCache API.
Apr 16 2019, 10:57 AM · Restricted Project
harlanhaskins committed rGeec3c0f9e304: [FileSystemStatCache] Return std::error_code from stat cache methods (authored by harlanhaskins).
[FileSystemStatCache] Return std::error_code from stat cache methods
Apr 16 2019, 10:33 AM
harlanhaskins committed rL358509: [FileSystemStatCache] Return std::error_code from stat cache methods.
[FileSystemStatCache] Return std::error_code from stat cache methods
Apr 16 2019, 10:32 AM
harlanhaskins committed rC358509: [FileSystemStatCache] Return std::error_code from stat cache methods.
[FileSystemStatCache] Return std::error_code from stat cache methods
Apr 16 2019, 10:32 AM
harlanhaskins closed D60735: [FileSystemStatCache] Return std::error_code from stat cache methods.
Apr 16 2019, 10:32 AM · Restricted Project

Apr 15 2019

harlanhaskins added a reviewer for D60735: [FileSystemStatCache] Return std::error_code from stat cache methods: arphaman.
Apr 15 2019, 3:38 PM · Restricted Project
harlanhaskins created D60735: [FileSystemStatCache] Return std::error_code from stat cache methods.
Apr 15 2019, 3:30 PM · Restricted Project

Mar 31 2019

harlanhaskins created D60051: [build] Only rewrite TableGen files if they've changed.
Mar 31 2019, 4:22 PM · Restricted Project

Mar 21 2019

harlanhaskins accepted D59658: [LLVM-C] Add bindings to insert basic blocks.
Mar 21 2019, 2:43 PM · Restricted Project

Mar 4 2019

harlanhaskins committed rG06f64d53ae5f: Replace clang::FileData with llvm::vfs::Status (authored by harlanhaskins).
Replace clang::FileData with llvm::vfs::Status
Mar 4 2019, 6:27 PM
harlanhaskins committed rC355368: Replace clang::FileData with llvm::vfs::Status.
Replace clang::FileData with llvm::vfs::Status
Mar 4 2019, 6:26 PM
harlanhaskins committed rL355368: Replace clang::FileData with llvm::vfs::Status.
Replace clang::FileData with llvm::vfs::Status
Mar 4 2019, 6:26 PM
harlanhaskins closed D58924: Replace clang::FileData with llvm::vfs::Status.
Mar 4 2019, 6:26 PM · Restricted Project, Restricted Project
harlanhaskins added inline comments to D58924: Replace clang::FileData with llvm::vfs::Status.
Mar 4 2019, 6:07 PM · Restricted Project, Restricted Project
harlanhaskins updated the summary of D58924: Replace clang::FileData with llvm::vfs::Status.
Mar 4 2019, 2:03 PM · Restricted Project, Restricted Project
harlanhaskins created D58924: Replace clang::FileData with llvm::vfs::Status.
Mar 4 2019, 2:03 PM · Restricted Project, Restricted Project

Feb 16 2019

harlanhaskins accepted D58323: [LLVM-C] Add bindings to create enumerators.

Thanks!

Feb 16 2019, 10:58 PM · Restricted Project

Oct 23 2018

harlanhaskins added a comment to D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.

LGTM, just needs a test.

Oct 23 2018, 9:57 AM

Apr 22 2018

harlanhaskins accepted D45928: [LLVM-C] Add DIBuilder Bindings For Variable Creation.
Apr 22 2018, 12:19 PM

Apr 10 2018

harlanhaskins accepted D45496: [LLVM-C] Add Missing 'break's in InlineAsm bindings.
Apr 10 2018, 11:12 AM

Apr 6 2018

harlanhaskins accepted D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.
Apr 6 2018, 8:04 PM
harlanhaskins requested changes to D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.

LGTM after that one small go style change.

Apr 6 2018, 4:03 PM

Apr 2 2018

harlanhaskins committed rL329021: Fix Go IR test for changes in DIBuilder API.
Fix Go IR test for changes in DIBuilder API
Apr 2 2018, 2:48 PM
harlanhaskins committed rL329003: Fix header mismatch in DIBuilder Type APIs.
Fix header mismatch in DIBuilder Type APIs
Apr 2 2018, 12:15 PM
harlanhaskins abandoned D45175: Fix header mismatch in DIBuilder Type APIs.
Apr 2 2018, 12:15 PM
harlanhaskins created D45175: Fix header mismatch in DIBuilder Type APIs.
Apr 2 2018, 12:10 PM

Apr 1 2018

harlanhaskins closed D39564: Add DIBuilder Type APIs to C API.

Closed by revision rL328953.

Apr 1 2018, 8:09 PM
harlanhaskins committed rL328953: Add C API bindings for DIBuilder 'Type' APIs.
Add C API bindings for DIBuilder 'Type' APIs
Apr 1 2018, 5:23 PM

Mar 29 2018

harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.

@whitequark Do the Go bindings changes look good to you? If so, I'll commit this.

Mar 29 2018, 12:54 PM

Mar 20 2018

harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.

@echristo Do these Go bindings changes look good?

Mar 20 2018, 1:15 PM
harlanhaskins updated the diff for D39564: Add DIBuilder Type APIs to C API.

Fix Go bindings

Mar 20 2018, 12:06 PM

Mar 15 2018

harlanhaskins updated the diff for D39564: Add DIBuilder Type APIs to C API.
  • Rebase on master
Mar 15 2018, 11:15 AM

Nov 4 2017

harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.

Before I commit this: @echristo this is also going to obviate some of the Go bindings and require changes...

Nov 4 2017, 1:49 PM
harlanhaskins committed rL317422: Use code voice for DIBuilder in LLVM C API.
Use code voice for DIBuilder in LLVM C API
Nov 4 2017, 1:31 PM

Nov 2 2017

harlanhaskins updated the diff for D39564: Add DIBuilder Type APIs to C API.
  • Update comments to /** style
  • Fix c-style doc comment
Nov 2 2017, 2:32 PM
harlanhaskins updated the diff for D39568: Clean up DIBuilder.h comments.
  • Fix remaining comment issues
Nov 2 2017, 2:25 PM
harlanhaskins added a reviewer for D39568: Clean up DIBuilder.h comments: aprantl.
Nov 2 2017, 2:13 PM
harlanhaskins updated the diff for D39568: Clean up DIBuilder.h comments.

Clean up DIBuilder.h comments

Nov 2 2017, 2:13 PM
harlanhaskins created D39568: Clean up DIBuilder.h comments.
Nov 2 2017, 2:11 PM
harlanhaskins updated subscribers of D39564: Add DIBuilder Type APIs to C API.
Nov 2 2017, 1:32 PM
harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.

This needs more comprehensive testing but I wanted to get an initial code review pass over this. Thanks y'all!

Nov 2 2017, 1:18 PM
harlanhaskins added reviewers for D39564: Add DIBuilder Type APIs to C API: whitequark, echristo, aprantl.
Nov 2 2017, 1:17 PM
harlanhaskins created D39564: Add DIBuilder Type APIs to C API.
Nov 2 2017, 1:17 PM

Nov 1 2017

harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.

Changes rebased on master.

Nov 1 2017, 3:01 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.

wq - Fix 80-column limit for LLVMDWARFSourceLanguage

  • Address comments
  • uint64_t -> size_t for string lengths
  • Add simple debuginfo tests
  • Fix unused variable warning
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
  • Add test and update CMakeLists to build debuginfo.c
  • Fix test
  • Use unsigned instead of explicitly sized unsigned integer types
  • Add comment explaining 0 for debug locations
  • Expand enum definitions and translate to DI (#1)
Nov 1 2017, 3:00 PM

Oct 31 2017

harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.

I don't have commit access -- would you mind merging it, @whitequark?

Oct 31 2017, 9:01 AM

Oct 30 2017

harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.

@whitequark Think this is good to merge in its current state? I have another patch for more functions Moreno or less ready to go once this is in.

Oct 30 2017, 7:50 PM

Sep 30 2017

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Added explicit enum definitions for C API DWARF values (Change made by @CodaFi)
Sep 30 2017, 3:12 PM

Jun 22 2017

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Add comment explaining 0 for debug locations
Jun 22 2017, 3:45 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 22 2017, 2:52 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 22 2017, 10:26 AM

Jun 21 2017

harlanhaskins updated the summary of D32368: LLVM C DIBuilder Creation APIs.
Jun 21 2017, 10:30 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 21 2017, 10:25 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Address comments
  • uint64_t -> size_t for string lengths
  • Add simple debuginfo tests
  • Fix unused variable warning
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
  • Add test and update CMakeLists to build debuginfo.c
  • Fix test
  • Use unsigned instead of explicitly sized unsigned integer types
Jun 21 2017, 9:29 PM

Jun 3 2017

harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 3 2017, 1:56 PM

Jun 2 2017

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Address comments
  • uint64_t -> size_t for string lengths
  • Add simple debuginfo tests
  • Fix unused variable warning
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
  • Add test and update CMakeLists to build debuginfo.c
Jun 2 2017, 9:19 PM

May 20 2017

harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
May 20 2017, 11:52 AM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • uint8_t -> LLVMBool for flags
  • ProducerLen should be size_t
May 20 2017, 11:51 AM

May 19 2017

harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix unused variable warning
May 19 2017, 12:14 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Add simple debuginfo tests
May 19 2017, 12:13 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • uint64_t -> size_t for string lengths
May 19 2017, 11:13 AM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Address comments
May 19 2017, 10:55 AM

Apr 22 2017

harlanhaskins added inline comments to D32152: Expose NoReturn attribute to libclang.
Apr 22 2017, 5:15 PM · Restricted Project

Apr 21 2017

harlanhaskins retitled D32152: Expose NoReturn attribute to libclang from Add clang_Cursor_isFunctionNoReturn to libclang to Expose NoReturn attribute to libclang.
Apr 21 2017, 1:44 PM · Restricted Project
harlanhaskins updated the diff for D32152: Expose NoReturn attribute to libclang.
  • Change noreturn interface to expose NoReturn as an attribute
Apr 21 2017, 1:43 PM · Restricted Project
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Apr 21 2017, 1:21 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Apr 21 2017, 1:17 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
  • Fix 80-column limit for LLVMDWARFSourceLanguage
  • Pass string parameters as pointer/length pairs
Apr 21 2017, 1:00 PM
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Apr 21 2017, 12:51 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.

Add back remanining files (sorry for the email spam!)

Apr 21 2017, 12:46 PM
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.

Fix 80-column limit for LLVMDWARFSourceLanguage

Apr 21 2017, 12:45 PM