User Details
User Details
- User Since
- Mar 18 2016, 1:16 PM (187 w, 4 d)
Sep 4 2019
Sep 4 2019
Request commit access for harlanhaskins on GitHub
Aug 1 2019
Aug 1 2019
harlanhaskins committed rGe86fffcd4489: Fix Windows branch of FileManagerTest changes (authored by harlanhaskins).
Fix Windows branch of FileManagerTest changes
Fix Windows branch of FileManagerTest changes
harlanhaskins committed rG5341f79a90bb: Fix use-after-move in ClangBasicTests (authored by harlanhaskins).
Fix use-after-move in ClangBasicTests
Fix use-after-move in ClangBasicTests
harlanhaskins committed rGa02f85768d2d: [clang-tools-extra] Adopt FileManager's error-returning APIs (authored by harlanhaskins).
[clang-tools-extra] Adopt FileManager's error-returning APIs
harlanhaskins committed rG84586c1423aa: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure (authored by harlanhaskins).
[clang] Change FileManager to use llvm::ErrorOr instead of null on failure
harlanhaskins committed rG8d323d150610: [clang] Adopt new FileManager error-returning APIs (authored by harlanhaskins).
[clang] Adopt new FileManager error-returning APIs
harlanhaskins committed rG461f0722dd26: [clang] Adopt llvm::ErrorOr in FileManager methods (authored by harlanhaskins).
[clang] Adopt llvm::ErrorOr in FileManager methods
harlanhaskins committed rL367618: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
[clang] Change FileManager to use llvm::ErrorOr instead of null on failure
[clang-tools-extra] Adopt FileManager's error-returning APIs
[clang] Adopt new FileManager error-returning APIs
[clang] Adopt llvm::ErrorOr in FileManager methods
harlanhaskins added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
harlanhaskins updated the diff for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Updated in response to feedback
Jul 31 2019
Jul 31 2019
harlanhaskins updated the diff for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
Store references instead of raw pointers in FileManger's cache
harlanhaskins added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
harlanhaskins added inline comments to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
harlanhaskins updated the summary of D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
harlanhaskins updated the summary of D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.
May 25 2019
May 25 2019
May 25 2019, 2:30 PM · Restricted Project
Apr 16 2019
Apr 16 2019
harlanhaskins committed rGd8f776af6ed9: [FileSystemStatCache] Update test for new FileSystemStatCache API (authored by harlanhaskins).
[FileSystemStatCache] Update test for new FileSystemStatCache API
harlanhaskins committed rL358511: [FileSystemStatCache] Update test for new FileSystemStatCache API.
[FileSystemStatCache] Update test for new FileSystemStatCache API
harlanhaskins committed rC358511: [FileSystemStatCache] Update test for new FileSystemStatCache API.
[FileSystemStatCache] Update test for new FileSystemStatCache API
Apr 16 2019, 11:01 AM · Restricted Project
Apr 16 2019, 10:57 AM · Restricted Project
harlanhaskins committed rGeec3c0f9e304: [FileSystemStatCache] Return std::error_code from stat cache methods (authored by harlanhaskins).
[FileSystemStatCache] Return std::error_code from stat cache methods
harlanhaskins committed rL358509: [FileSystemStatCache] Return std::error_code from stat cache methods.
[FileSystemStatCache] Return std::error_code from stat cache methods
harlanhaskins committed rC358509: [FileSystemStatCache] Return std::error_code from stat cache methods.
[FileSystemStatCache] Return std::error_code from stat cache methods
Apr 16 2019, 10:32 AM · Restricted Project
Apr 15 2019
Apr 15 2019
harlanhaskins added a reviewer for D60735: [FileSystemStatCache] Return std::error_code from stat cache methods: arphaman.
Apr 15 2019, 3:38 PM · Restricted Project
Apr 15 2019, 3:30 PM · Restricted Project
Mar 31 2019
Mar 31 2019
Mar 31 2019, 4:22 PM · Restricted Project
Mar 21 2019
Mar 21 2019
Mar 21 2019, 2:43 PM · Restricted Project
Mar 4 2019
Mar 4 2019
harlanhaskins committed rG06f64d53ae5f: Replace clang::FileData with llvm::vfs::Status (authored by harlanhaskins).
Replace clang::FileData with llvm::vfs::Status
Replace clang::FileData with llvm::vfs::Status
Replace clang::FileData with llvm::vfs::Status
harlanhaskins added inline comments to D58924: Replace clang::FileData with llvm::vfs::Status.
harlanhaskins updated the summary of D58924: Replace clang::FileData with llvm::vfs::Status.
Feb 16 2019
Feb 16 2019
Thanks!
Feb 16 2019, 10:58 PM · Restricted Project
Oct 23 2018
Oct 23 2018
harlanhaskins added a comment to D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.
LGTM, just needs a test.
Apr 22 2018
Apr 22 2018
Apr 10 2018
Apr 10 2018
Apr 6 2018
Apr 6 2018
harlanhaskins requested changes to D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.
LGTM after that one small go style change.
Apr 2 2018
Apr 2 2018
Fix Go IR test for changes in DIBuilder API
Fix header mismatch in DIBuilder Type APIs
Apr 1 2018
Apr 1 2018
Closed by revision rL328953.
Add C API bindings for DIBuilder 'Type' APIs
Mar 29 2018
Mar 29 2018
harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.
@whitequark Do the Go bindings changes look good to you? If so, I'll commit this.
Mar 20 2018
Mar 20 2018
harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.
@echristo Do these Go bindings changes look good?
harlanhaskins updated the diff for D39564: Add DIBuilder Type APIs to C API.
Fix Go bindings
Mar 15 2018
Mar 15 2018
harlanhaskins updated the diff for D39564: Add DIBuilder Type APIs to C API.
- Rebase on master
Nov 4 2017
Nov 4 2017
harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.
Before I commit this: @echristo this is also going to obviate some of the Go bindings and require changes...
Use code voice for DIBuilder in LLVM C API
Nov 2 2017
Nov 2 2017
harlanhaskins updated the diff for D39564: Add DIBuilder Type APIs to C API.
- Update comments to /** style
- Fix c-style doc comment
harlanhaskins updated the diff for D39568: Clean up DIBuilder.h comments.
- Fix remaining comment issues
harlanhaskins updated the diff for D39568: Clean up DIBuilder.h comments.
Clean up DIBuilder.h comments
harlanhaskins updated subscribers of D39564: Add DIBuilder Type APIs to C API.
harlanhaskins added a comment to D39564: Add DIBuilder Type APIs to C API.
This needs more comprehensive testing but I wanted to get an initial code review pass over this. Thanks y'all!
harlanhaskins added reviewers for D39564: Add DIBuilder Type APIs to C API: whitequark, echristo, aprantl.
Nov 1 2017
Nov 1 2017
harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.
Changes rebased on master.
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
wq - Fix 80-column limit for LLVMDWARFSourceLanguage
- Address comments
- uint64_t -> size_t for string lengths
- Add simple debuginfo tests
- Fix unused variable warning
- uint8_t -> LLVMBool for flags
- ProducerLen should be size_t
- Add test and update CMakeLists to build debuginfo.c
- Fix test
- Use unsigned instead of explicitly sized unsigned integer types
- Add comment explaining 0 for debug locations
- Expand enum definitions and translate to DI (#1)
Oct 31 2017
Oct 31 2017
harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.
I don't have commit access -- would you mind merging it, @whitequark?
Oct 30 2017
Oct 30 2017
harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.
@whitequark Think this is good to merge in its current state? I have another patch for more functions Moreno or less ready to go once this is in.
Sep 30 2017
Sep 30 2017
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Added explicit enum definitions for C API DWARF values (Change made by @CodaFi)
Jun 22 2017
Jun 22 2017
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Add comment explaining 0 for debug locations
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 21 2017
Jun 21 2017
harlanhaskins updated the summary of D32368: LLVM C DIBuilder Creation APIs.
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Fix 80-column limit for LLVMDWARFSourceLanguage
- Address comments
- uint64_t -> size_t for string lengths
- Add simple debuginfo tests
- Fix unused variable warning
- uint8_t -> LLVMBool for flags
- ProducerLen should be size_t
- Add test and update CMakeLists to build debuginfo.c
- Fix test
- Use unsigned instead of explicitly sized unsigned integer types
Jun 3 2017
Jun 3 2017
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
Jun 2 2017
Jun 2 2017
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Fix 80-column limit for LLVMDWARFSourceLanguage
- Address comments
- uint64_t -> size_t for string lengths
- Add simple debuginfo tests
- Fix unused variable warning
- uint8_t -> LLVMBool for flags
- ProducerLen should be size_t
- Add test and update CMakeLists to build debuginfo.c
May 20 2017
May 20 2017
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- uint8_t -> LLVMBool for flags
- ProducerLen should be size_t
May 19 2017
May 19 2017
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Fix unused variable warning
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Add simple debuginfo tests
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- uint64_t -> size_t for string lengths
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Fix 80-column limit for LLVMDWARFSourceLanguage
- Address comments
Apr 22 2017
Apr 22 2017
harlanhaskins added inline comments to D32152: Expose NoReturn attribute to libclang.
Apr 22 2017, 5:15 PM · Restricted Project
Apr 21 2017
Apr 21 2017
harlanhaskins retitled D32152: Expose NoReturn attribute to libclang from Add clang_Cursor_isFunctionNoReturn to libclang to Expose NoReturn attribute to libclang.
Apr 21 2017, 1:44 PM · Restricted Project
harlanhaskins updated the diff for D32152: Expose NoReturn attribute to libclang.
- Change noreturn interface to expose NoReturn as an attribute
Apr 21 2017, 1:43 PM · Restricted Project
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
- Fix 80-column limit for LLVMDWARFSourceLanguage
- Pass string parameters as pointer/length pairs
harlanhaskins added inline comments to D32368: LLVM C DIBuilder Creation APIs.
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
Add back remanining files (sorry for the email spam!)
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
Fix 80-column limit for LLVMDWARFSourceLanguage
harlanhaskins updated the diff for D32368: LLVM C DIBuilder Creation APIs.
Fix merge head
harlanhaskins added a comment to D32368: LLVM C DIBuilder Creation APIs.
arc...picked some wrong branches here. I'll fix this diff 😅