Page MenuHomePhabricator

libcxx 'LLVM_USE_SANITIZER=Address;Undefined'
ClosedPublic

Authored by modocache on Apr 4 2020, 10:22 AM.

Details

Reviewers
jroelofs
EricWF
ldionne
Group Reviewers
Restricted Project
Commits
rG54176d1766f2: libcxx 'LLVM_USE_SANITIZER=Address;Undefined'
Summary

Allow users to simultaneously enable address and undefined behavior
sanitizers, in the same manner that LLVM's 'HandleLLVMOptions.cmake'
allows.

Prior to this patch, cmake -DLLVM_USE_SANITIZER="Address;Undefined"
would succeed and the build would build most of the LLVM project with
-fsanitize=address,undefined, but a warning would be printed by
libcxx's CMake, and the build would use neither sanitizer. This
patch results in no warning being printed, and both sanitizers are used
in building libcxx.

Diff Detail

Event Timeline

modocache created this revision.Apr 4 2020, 10:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2020, 10:22 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
jroelofs accepted this revision.Apr 4 2020, 1:14 PM

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 4 2020, 1:50 PM
This revision was automatically updated to reflect the committed changes.

@modocache We have a libcxx review group that gets added as a blocking reviewer on libcxx patches automatically, that's for a reason. Please don't commit without an approval from the group anymore.

The patch looks good to me.