Page MenuHomePhabricator

[WebAssembly] Fix a sanitizer error in WasmEHPrepare
ClosedPublic

Authored by aheejin on Apr 4 2020, 9:55 AM.

Details

Summary

D77423 started using a dominator tree in WasmEHPrepare, but we deleted
BBs in prepareThrows before we used the domtree in prepareEHPads,
and those CFG changes were not reflected in the domtree. This uses
DomTreeUpdater to make sure we update the domtree every time we delete
BBs from the CFG. This fixes ubsan/msan/expensive_check errors caught in
LLVM buildbots.

Diff Detail

Event Timeline

aheejin created this revision.Apr 4 2020, 9:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2020, 9:55 AM

Will land this now, because it's a weekend and the previous patch is breaking the buildbots.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 4 2020, 10:04 AM
This revision was automatically updated to reflect the committed changes.