libclc: Don't pass linker flags to CLC/LLAsm

[daniels]

Summary

We don't want the regular linker flags for these invocations, since
we're not compiling to the target machine anyway. This fixes things like
'/machine:x64' being unknown when invoked under Windows.

Depends on: D77163

[jvesely]

Have you tried clearing the target link flags using set_target_properties( ... LINK_FLAGS ... )?
I think having the ability to pass LINK_FLAGS here might be useful in the future.

[daniels]

In D77164#1958232, @jvesely wrote:

Have you tried clearing the target link flags using set_target_properties( ... LINK_FLAGS ... )?
I think having the ability to pass LINK_FLAGS here might be useful in the future.

I tried, but the manual says that a) you must use STATIC_LIBRARY_FLAGS for static libraries, and b) you must use STATIC_LIBRARY_OPTIONS in preference to the former, as it sets rather than appends.

Nevertheless, neither of them actually worked for me, and both continued to pass the machine linker flags.

[daniels]

rebase

[jvesely]

In D77164#1965305, @daniels wrote:

In D77164#1958232, @jvesely wrote:

Have you tried clearing the target link flags using set_target_properties( ... LINK_FLAGS ... )?
I think having the ability to pass LINK_FLAGS here might be useful in the future.

I tried, but the manual says that a) you must use STATIC_LIBRARY_FLAGS for static libraries, and b) you must use STATIC_LIBRARY_OPTIONS in preference to the former, as it sets rather than appends.

Nevertheless, neither of them actually worked for me, and both continued to pass the machine linker flags.

oh well, it's not like we need any flags now. Thanks for checking.
LGTM.

libclc/cmake/CMakeCLCInformation.cmake

 if(NOT CMAKE_CLC_COMPILE_OBJECT)
   set(CMAKE_CLC_COMPILE_OBJECT
     "<CMAKE_CLC_COMPILER> <DEFINES> <INCLUDES> <FLAGS> -o <OBJECT> -c <SOURCE> -emit-llvm")
 endif()
 
 if(NOT CMAKE_CLC_CREATE_STATIC_LIBRARY)
   set(CMAKE_CLC_CREATE_STATIC_LIBRARY
-    "<CMAKE_CLC_ARCHIVE> <LINK_FLAGS> -o <TARGET> <OBJECTS>")
+    "<CMAKE_CLC_ARCHIVE> -o <TARGET> <OBJECTS>")
 endif()
 
 set(CMAKE_INCLUDE_FLAG_CLC "-I")

libclc/cmake/CMakeLLAsmInformation.cmake

 if(NOT CMAKE_LLAsm_COMPILE_OBJECT)
   set(CMAKE_LLAsm_COMPILE_OBJECT
     "${CMAKE_LLAsm_PREPROCESSOR} -E -P  <DEFINES> <INCLUDES> <FLAGS> -x cl  <SOURCE> -o - | <CMAKE_LLAsm_COMPILER> -o <OBJECT> ")
 endif()
 
 if(NOT CMAKE_LLAsm_CREATE_STATIC_LIBRARY)
   set(CMAKE_LLAsm_CREATE_STATIC_LIBRARY
-    "<CMAKE_LLAsm_ARCHIVE> <LINK_FLAGS> -o <TARGET> <OBJECTS>")
+    "<CMAKE_LLAsm_ARCHIVE> -o <TARGET> <OBJECTS>")
 endif()
 
 set(CMAKE_INCLUDE_FLAG_LLAsm "-I")