Page MenuHomePhabricator

[pch] Honour -fallow-pch-with-compiler-errors for overall compilation status
ClosedPublic

Authored by benlangmuir on Mar 31 2020, 12:13 PM.

Details

Summary
Previously we would emit a PCH with errors, but fail the overall
compilation. If run using the driver, that would result in removing the
just-produced PCH. Instead, we should have the compilation result match
whether we were able to emit the PCH.

rdar://61110294

Diff Detail

Event Timeline

benlangmuir created this revision.Mar 31 2020, 12:13 PM
akyrtzi accepted this revision.Mar 31 2020, 1:33 PM
This revision is now accepted and ready to land.Mar 31 2020, 1:33 PM
This revision was automatically updated to reflect the committed changes.