Page MenuHomePhabricator

[clang] Move branch-protection from CodeGenOptions to LangOptions
ClosedPublic

Authored by tamas.petz on Mar 31 2020, 3:59 AM.

Diff Detail

Event Timeline

tamas.petz created this revision.Mar 31 2020, 3:59 AM

just a nit, LGTM otherwise.

clang/include/clang/Basic/CodeGenOptions.def
403

is this change necessary?

tamas.petz marked an inline comment as done.Mar 31 2020, 4:12 AM
tamas.petz added inline comments.
clang/include/clang/Basic/CodeGenOptions.def
403

I think there should be one new line at the end of the file, not two.

tamas.petz edited reviewers, added: chill; removed: momchil.velikov.Apr 1 2020, 1:27 AM

Tests pass, however, I am not sure ParseLangArgs is called in all the necessary cases (see the occurrences in the code).

chill added a subscriber: efriedma.
clang/include/clang/Basic/TargetInfo.h
19

This include is probably not needed anymore.

tamas.petz updated this revision to Diff 254174.Apr 1 2020, 5:49 AM

Address review comments.

tamas.petz marked an inline comment as done.Apr 1 2020, 5:50 AM
efriedma accepted this revision.Apr 1 2020, 1:47 PM

LGTM

This revision is now accepted and ready to land.Apr 1 2020, 1:47 PM
This revision was automatically updated to reflect the committed changes.