Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People tamas.petz

tamas.petz (Tamas Petz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2020, 3:41 AM (189 w, 5 d)

Recent Activity
View All

Jun 3 2021

tamas.petz added a comment to D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP).

LGTM

Jun 3 2021, 5:49 AM · Restricted Project, Restricted Project

May 10 2021

tamas.petz added a comment to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.

I have just a few small comments.

May 10 2021, 9:30 AM · Restricted Project, Restricted Project

Apr 15 2021

tamas.petz added inline comments to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
Apr 15 2021, 4:22 AM · Restricted Project, Restricted Project

Sep 29 2020

tamas.petz accepted D77786: [AArch64] Add v8.5 Branch Target Identification support..

LGTM

Sep 29 2020, 4:52 AM · Restricted Project, Restricted Project
tamas.petz accepted D81251: [AArch64] Add BTI to CFI jumptables..
Sep 29 2020, 4:32 AM · Restricted Project
tamas.petz added a comment to D81251: [AArch64] Add BTI to CFI jumptables..

LGTM after the minor change

Sep 29 2020, 4:29 AM · Restricted Project

Jun 15 2020

tamas.petz accepted D81746: [AArch64] Fix BTI instruction emission..

LGTM

Jun 15 2020, 5:56 AM · Restricted Project

Apr 15 2020

tamas.petz abandoned D75364: [clang-format] Handle macros in function params and return value.
In D75364#1966818, @MyDeveloperDay wrote:
In D75364#1966743, @tamas.petz wrote:

Wow, I have missed that configuration option.
I will try it, I assume it should work.

Looks like this change should be abandoned.

To be honest, I forget what we've got too! ;-) I was just writing a reply that said "how about adding an option with a list of type macros", I was looking for an example of other places we do that, and stumbled on it.

Apr 15 2020, 12:30 AM · Restricted Project, Restricted Project

Apr 7 2020

tamas.petz added inline comments to D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Apr 7 2020, 10:50 AM · Restricted Project, Restricted Project
tamas.petz added a comment to D75364: [clang-format] Handle macros in function params and return value.

Wow, I have missed that configuration option.
I will try it, I assume it should work.

Apr 7 2020, 5:23 AM · Restricted Project, Restricted Project
tamas.petz added a comment to D75364: [clang-format] Handle macros in function params and return value.

@all, thank you for the review so far.

Apr 7 2020, 1:03 AM · Restricted Project, Restricted Project

Apr 3 2020

tamas.petz added inline comments to D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Apr 3 2020, 9:07 AM · Restricted Project, Restricted Project

Apr 1 2020

tamas.petz updated the diff for D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions.

Address review comments.

Apr 1 2020, 6:02 AM · Restricted Project
tamas.petz added a comment to D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions.

Tests pass, however, I am not sure ParseLangArgs is called in all the necessary cases (see the occurrences in the code).

Apr 1 2020, 1:36 AM · Restricted Project
tamas.petz edited reviewers for D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines, added: chill; removed: momchil.velikov.
Apr 1 2020, 1:36 AM · Restricted Project
tamas.petz edited reviewers for D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions, added: chill; removed: momchil.velikov.
Apr 1 2020, 1:36 AM · Restricted Project

Mar 31 2020

tamas.petz created D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines.
Mar 31 2020, 4:23 AM · Restricted Project
tamas.petz added inline comments to D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions.
Mar 31 2020, 4:23 AM · Restricted Project
tamas.petz added a comment to D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines.

Depends on: https://reviews.llvm.org/D77131

Mar 31 2020, 4:23 AM · Restricted Project
tamas.petz created D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions.
Mar 31 2020, 4:23 AM · Restricted Project

Mar 30 2020

tamas.petz added a comment to D75364: [clang-format] Handle macros in function params and return value.

Friendly ping.

Mar 30 2020, 5:22 AM · Restricted Project, Restricted Project

Mar 2 2020

tamas.petz updated the diff for D75364: [clang-format] Handle macros in function params and return value.
Mar 2 2020, 12:02 AM · Restricted Project, Restricted Project

Feb 28 2020

tamas.petz created D75364: [clang-format] Handle macros in function params and return value.
Feb 28 2020, 9:38 AM · Restricted Project, Restricted Project

Feb 19 2020

tamas.petz created D74827: [LLD][ELF][ARM] Add test cases for R_ARM_THM_MOV*-type relocs.
Feb 19 2020, 5:23 AM · lld, Restricted Project

Feb 18 2020

tamas.petz added a comment to D74604: [LLD][ELF][ARM] Fix support for SBREL type relocations.

Thank you, Peter.
Yes, add the missing /-es and commit this change on my behalf, please.
I will add the missing test cases shortly after.

Feb 18 2020, 8:53 AM · Restricted Project, lld
tamas.petz updated the diff for D74604: [LLD][ELF][ARM] Fix support for SBREL type relocations.
Feb 18 2020, 4:47 AM · Restricted Project, lld
tamas.petz added inline comments to D74604: [LLD][ELF][ARM] Fix support for SBREL type relocations.
Feb 18 2020, 12:33 AM · Restricted Project, lld

Feb 17 2020

tamas.petz added a comment to D74603: [AARCH64] Fix small typos in the target description.

Thank you for the review.
Unfortunately I don't have commit access.
Would you please submit this change on my behalf?

Feb 17 2020, 2:11 AM · Restricted Project

Feb 14 2020

tamas.petz created D74604: [LLD][ELF][ARM] Fix support for SBREL type relocations.
Feb 14 2020, 4:34 AM · Restricted Project, lld
tamas.petz created D74603: [AARCH64] Fix small typos in the target description.
Feb 14 2020, 4:17 AM · Restricted Project