Page MenuHomePhabricator

[Alignment][NFC] Simplify IRTranslator::getMemOpAlignment
ClosedPublic

Authored by gchatelet on Mar 30 2020, 11:51 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Diff Detail

Event Timeline

gchatelet created this revision.Mar 30 2020, 11:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2020, 11:51 AM
courbet accepted this revision.Mar 30 2020, 11:42 PM
courbet added inline comments.
llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
246–247

you can now remove all the else if statements:

if (const StoreInst *SI = dyn_cast<StoreInst>(&I)) {
  return ...;
}
if (...) {
  return ...;
}
This revision is now accepted and ready to land.Mar 30 2020, 11:42 PM
gchatelet marked an inline comment as done.
  • Address comments
This revision was automatically updated to reflect the committed changes.