This is an archive of the discontinued LLVM Phabricator instance.

Differential D77075

[Statepoint] Fix StatepointLoweringInfo::GCTransitionArgs initialization
ClosedPublic

Authored by dantrushin on Mar 30 2020, 10:27 AM.

Details

Reviewers
reames
skatkov
Commits
rG47107dc3bda1: [Statepoint] Fix StatepointLoweringInfo::GCTransitionArgs initialization
Summary

In method SelectionDAGBuilder::LowerStatepoint, array SI.GCTransitionArgs
is initialized from wrong part of ImmutableStatepoint class.
We copy gc args instead of transitions args.

Diff Detail

Unit TestsFailed

TimeTest
140 mslldb-unit.Host/_/HostTests::Unknown Unit Message ("")

Event Timeline

dantrushin created this revision.Mar 30 2020, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2020, 10:27 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
Harbormaster failed remote builds in B50984: Diff 253633!Mar 30 2020, 11:24 AM
skatkov accepted this revision.Mar 30 2020, 9:12 PM
This revision is now accepted and ready to land.Mar 30 2020, 9:12 PM
Closed by commit rG47107dc3bda1: [Statepoint] Fix StatepointLoweringInfo::GCTransitionArgs initialization (authored by dantrushin). · Explain WhyMar 31 2020, 2:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
4 lines

Diff 253633

llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp

Show First 20 Lines • Show All 843 Lines • ▼ Show 20 Lines for (const GCRelocateInst *Relocate : ISP.getRelocates()) {
if (Seen.insert(DerivedSD).second) { if (Seen.insert(DerivedSD).second) {
SI.Bases.push_back(Relocate->getBasePtr()); SI.Bases.push_back(Relocate->getBasePtr());
SI.Ptrs.push_back(Relocate->getDerivedPtr()); SI.Ptrs.push_back(Relocate->getDerivedPtr());
} }
} }
SI.GCArgs = ArrayRef<const Use>(ISP.gc_args_begin(), ISP.gc_args_end()); SI.GCArgs = ArrayRef<const Use>(ISP.gc_args_begin(), ISP.gc_args_end());
SI.StatepointInstr = ISP.getInstruction(); SI.StatepointInstr = ISP.getInstruction();
SI.GCTransitionArgs = SI.GCTransitionArgs = ArrayRef<const Use>(ISP.gc_transition_args_begin(),
ArrayRef<const Use>(ISP.gc_args_begin(), ISP.gc_args_end()); ISP.gc_transition_args_end());
SI.ID = ISP.getID(); SI.ID = ISP.getID();
SI.DeoptState = ArrayRef<const Use>(ISP.deopt_begin(), ISP.deopt_end()); SI.DeoptState = ArrayRef<const Use>(ISP.deopt_begin(), ISP.deopt_end());
SI.StatepointFlags = ISP.getFlags(); SI.StatepointFlags = ISP.getFlags();
SI.NumPatchBytes = ISP.getNumPatchBytes(); SI.NumPatchBytes = ISP.getNumPatchBytes();
SI.EHPadBB = EHPadBB; SI.EHPadBB = EHPadBB;
SDValue ReturnValue = LowerAsSTATEPOINT(SI); SDValue ReturnValue = LowerAsSTATEPOINT(SI);
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines