This is an archive of the discontinued LLVM Phabricator instance.

Differential D76940

[lit] Avoid global imports in module declaration
ClosedPublic

Authored by yln on Mar 27 2020, 10:52 AM.

Details

Reviewers
paquette
Commits
rG8896d123154c: [lit] Avoid global imports in module declaration
Summary

A previous attempt to cleanup module imports broke installing via
pip/setup.py [1]. This should be fixed now.

[1] cf252240e8819d0c90a5e10f773078bdeba33e44

Diff Detail

Event Timeline

yln created this revision.Mar 27 2020, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2020, 10:52 AM
Herald added subscribers: llvm-commits, delcypher. · View Herald Transcript
yln retitled this revision from [lir] Avoid global imports in module declaration to [lit] Avoid global imports in module declaration.Mar 27 2020, 10:52 AM
yln edited the summary of this revision. (Show Details)
paquette accepted this revision.Mar 27 2020, 11:23 AM

LGTM

This revision is now accepted and ready to land.Mar 27 2020, 11:23 AM
Harbormaster failed remote builds in B50710: Diff 253170!Mar 27 2020, 11:28 AM
Closed by commit rG8896d123154c: [lit] Avoid global imports in module declaration (authored by yln). · Explain WhyMar 27 2020, 12:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
utils/
lit/
lit/
1 line
2 lines

Diff 253195

llvm/utils/lit/lit/__init__.py

"""'lit' Testing Tool""" """'lit' Testing Tool"""
__author__ = 'Daniel Dunbar' __author__ = 'Daniel Dunbar'
__email__ = 'daniel@minormatter.com' __email__ = 'daniel@minormatter.com'
__versioninfo__ = (0, 11, 0) __versioninfo__ = (0, 11, 0)
__version__ = '.'.join(str(v) for v in __versioninfo__) + 'dev' __version__ = '.'.join(str(v) for v in __versioninfo__) + 'dev'
__all__ = [] __all__ = []
from .main import main

llvm/utils/lit/setup.py

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines classifiers=[
'Programming Language :: Python', 'Programming Language :: Python',
'Topic :: Software Development :: Testing', 'Topic :: Software Development :: Testing',
], ],
zip_safe = False, zip_safe = False,
packages = find_packages(), packages = find_packages(),
entry_points = { entry_points = {
'console_scripts': [ 'console_scripts': [
'lit = lit:main', 'lit = lit.main:main',
], ],
} }
) )