This is an archive of the discontinued LLVM Phabricator instance.

Differential D76905

[libc++] Fix wrong default value for LIBCXX_ENABLE_ASSERTIONS in documentation
ClosedPublic

Authored by tambre on Mar 26 2020, 11:57 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG094b11c3ab41: [libc++] Fix wrong default value for LIBCXX_ENABLE_ASSERTIONS in documentation
Summary

It's set to OFF by default at libcxx/CMakeLists.txt:73.

Diff Detail

Event Timeline

tambre created this revision.Mar 26 2020, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 11:57 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, dexonsmith. · View Herald Transcript
Harbormaster completed remote builds in B50659: Diff 253047.Mar 27 2020, 12:29 AM
ldionne accepted this revision.Mar 30 2020, 6:29 AM

Thanks for the patch!

This revision is now accepted and ready to land.Mar 30 2020, 6:29 AM
ldionne added a comment.Mar 30 2020, 6:29 AM

Do you have commit access? If not, please mention the full name and email address you need this to be committed under.

tambre added a comment.EditedMar 30 2020, 7:10 AM
In D76905#1949801, @ldionne wrote:

Do you have commit access? If not, please mention the full name and email address you need this to be committed under.

I do not.
Please commit as: "Raul Tambre" <raul@tambre.ee>

I'll make sure to include this in future reviews.

ldionne added a comment.Mar 30 2020, 9:45 AM
In D76905#1949880, @tambre wrote:
In D76905#1949801, @ldionne wrote:

Do you have commit access? If not, please mention the full name and email address you need this to be committed under.

I do not.
Please commit as: "Raul Tambre" <raul@tambre.ee>

I'll make sure to include this in future reviews.

Actually, you uploaded the patch with arc diff and the details were already included correctly in the patch. I didn't need to ask. Thanks a lot!

Closed by commit rG094b11c3ab41: [libc++] Fix wrong default value for LIBCXX_ENABLE_ASSERTIONS in documentation (authored by tambre, committed by ldionne). · Explain WhyMar 30 2020, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
docs/
2 lines

Diff 253620

libcxx/docs/BuildingLibcxx.rst

Show First 20 Lines • Show All 160 Lines • ▼ Show 20 Lines
.. option:: LIBCXX_INSTALL_HEADERS:BOOL .. option:: LIBCXX_INSTALL_HEADERS:BOOL
**Default**: ``ON`` **Default**: ``ON``
Toggle the installation of the libc++ headers. Toggle the installation of the libc++ headers.
.. option:: LIBCXX_ENABLE_ASSERTIONS:BOOL .. option:: LIBCXX_ENABLE_ASSERTIONS:BOOL
**Default**: ``ON`` **Default**: ``OFF``
Build libc++ with assertions enabled. Build libc++ with assertions enabled.
.. option:: LIBCXX_BUILD_32_BITS:BOOL .. option:: LIBCXX_BUILD_32_BITS:BOOL
**Default**: ``OFF`` **Default**: ``OFF``
Build libc++ as a 32 bit library. Also see `LLVM_BUILD_32_BITS`. Build libc++ as a 32 bit library. Also see `LLVM_BUILD_32_BITS`.
▲ Show 20 Lines • Show All 372 Lines • Show Last 20 Lines