Page MenuHomePhabricator

[libc++] Fix wrong default value for LIBCXX_ENABLE_ASSERTIONS in documentation
ClosedPublic

Authored by tambre on Mar 26 2020, 11:57 PM.

Details

Summary

It's set to OFF by default at libcxx/CMakeLists.txt:73.

Diff Detail

Event Timeline

tambre created this revision.Mar 26 2020, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 11:57 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Mar 30 2020, 6:29 AM

Thanks for the patch!

This revision is now accepted and ready to land.Mar 30 2020, 6:29 AM

Do you have commit access? If not, please mention the full name and email address you need this to be committed under.

tambre added a comment.EditedMar 30 2020, 7:10 AM

Do you have commit access? If not, please mention the full name and email address you need this to be committed under.

I do not.
Please commit as: "Raul Tambre" <raul@tambre.ee>

I'll make sure to include this in future reviews.

Do you have commit access? If not, please mention the full name and email address you need this to be committed under.

I do not.
Please commit as: "Raul Tambre" <raul@tambre.ee>

I'll make sure to include this in future reviews.

Actually, you uploaded the patch with arc diff and the details were already included correctly in the patch. I didn't need to ask. Thanks a lot!

This revision was automatically updated to reflect the committed changes.