Page MenuHomePhabricator

[X86][NFC] Generalize the naming of "Retpoline Thunks" and related code to "Indirect Thunks" [1/3]
ClosedPublic

Authored by sconstab on Mar 25 2020, 4:34 PM.

Details

Diff Detail

Event Timeline

sconstab created this revision.Mar 25 2020, 4:34 PM
zbrid added a comment.Mar 30 2020, 9:37 AM

Awesome. Looks good to me! Please wait for an LGTM from another LLVM contributor before merging.

llvm/lib/Target/X86/X86FrameLowering.cpp
2688

Does this comment need to be updated retpoline -> indirect thunks?

llvm/lib/Target/X86/X86ISelLowering.cpp
31950

Jw, why add external here?

llvm/lib/Target/X86/X86IndirectThunks.cpp
10

Might be useful to keep a description of a retpoline in the top of this?

Like:
The currently supported thunks are:
retpoline - a RET-implemented trampoline that is used to lower indirect calls

17

Thanks for adding this documentation!

zbrid retitled this revision from [X86] Generalize the naming of "Retpoline Thunks" and related code to "Indirect Thunks" [1/3] to [X86][NFC] Generalize the naming of "Retpoline Thunks" and related code to "Indirect Thunks" [1/3].Mar 30 2020, 9:37 AM
craig.topper added inline comments.Mar 30 2020, 1:32 PM
llvm/lib/Target/X86/X86ISelLowering.cpp
31914

This comment needs updating.

sconstab updated this revision to Diff 253883.Mar 31 2020, 7:32 AM

Updated to address @zbrid and @craig.topper 's comments.

This revision is now accepted and ready to land.Apr 1 2020, 11:11 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 2 2020, 10:13 PM