Page MenuHomePhabricator

[ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test
ClosedPublic

Authored by aganea on Mar 25 2020, 7:34 AM.

Details

Summary

As suggested here: https://reviews.llvm.org/D18487#1940131 make the test rely on llvm-dis instead. Also test the ICALL-PROM part as intended originally.

Diff Detail

Event Timeline

aganea created this revision.Mar 25 2020, 7:34 AM
tejohnson added inline comments.Mar 25 2020, 8:17 AM
llvm/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll
22

Is it possible to make this check on the output of llvm-dis on the .opt.bc file?

aganea updated this revision to Diff 252602.Mar 25 2020, 9:43 AM
aganea marked an inline comment as done.
aganea edited the summary of this revision. (Show Details)

As requested.

tejohnson accepted this revision.Mar 25 2020, 9:50 AM

LGTM thanks!

This revision is now accepted and ready to land.Mar 25 2020, 9:50 AM
This revision was automatically updated to reflect the committed changes.