Page MenuHomePhabricator

[docs][Phabricator] git migration related update
ClosedPublic

Authored by jsji on Mar 24 2020, 11:22 AM.

Details

Summary

1.Add instructions to update author when committing other's patch

We have updated DeveloperPolicy to show how to change author in
https://reviews.llvm.org/D72468

We should also update Phabricator page to include such infomation,
in case people follow the steps here and forget to update author info.

  1. Replace git llvm push with git push

Diff Detail

Event Timeline

jsji created this revision.Mar 24 2020, 11:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2020, 11:22 AM

Content looks fine, one style note.

llvm/docs/Phabricator.rst
198

Don't start a sentence with "eg." Instead use "For example, ensure ..."

jsji updated this revision to Diff 252673.Mar 25 2020, 2:25 PM

Address comments

jsji marked an inline comment as done.
This revision is now accepted and ready to land.Mar 26 2020, 8:28 AM
This revision was automatically updated to reflect the committed changes.