This is an archive of the discontinued LLVM Phabricator instance.

Differential D76654

[mlir] On Windows, silence warning on functions definition
ClosedPublic

Authored by aganea on Mar 23 2020, 5:21 PM.

Details

Reviewers
nicolasvasilache
Commits
rG667781592a44: [mlir] On Windows, silence warning on functions definition
Summary

This fixes the following warnings, where a function is re-defined after it is tagged as "being imported":

D:\llvm-project\mlir\lib\ExecutionEngine\CRunnerUtils.cpp(24,17): warning: 'print_i32' redeclared without 'dllimport' attribute: 'dllexport' attribute added [-Winconsistent-dllimport]
extern "C" void print_i32(int32_t i) { fprintf(stdout, "%" PRId32, i); }
                ^
D:\llvm-project\mlir\include\mlir/ExecutionEngine/CRunnerUtils.h(168,42): note: previous declaration is here
extern "C" MLIR_CRUNNERUTILS_EXPORT void print_i32(int32_t i);
                                         ^

Diff Detail

Event Timeline

aganea created this revision.Mar 23 2020, 5:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2020, 5:21 PM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 10 others. · View Herald Transcript
aartbik added inline comments.Mar 23 2020, 5:41 PM
mlir/lib/ExecutionEngine/CRunnerUtils.cpp
24

some whitespace was introduced here by mistake

35

missing newline

aganea updated this revision to Diff 252190.Mar 23 2020, 5:46 PM
aganea marked 2 inline comments as done.

Updated as requested.

Harbormaster failed remote builds in B50187: Diff 252180!Mar 23 2020, 5:59 PM
aganea added a comment.Mar 26 2020, 7:57 AM

Any further comments here? Can I go ahead with this?

nicolasvasilache accepted this revision.Mar 26 2020, 8:22 AM
This revision is now accepted and ready to land.Mar 26 2020, 8:22 AM
Closed by commit rG667781592a44: [mlir] On Windows, silence warning on functions definition (authored by aganea). · Explain WhyMar 27 2020, 9:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
include/
mlir/
ExecutionEngine/
2 lines
lib/
ExecutionEngine/
4 lines

Diff 253152

mlir/include/mlir/ExecutionEngine/CRunnerUtils.h

Show All 14 Lines
#ifndef EXECUTIONENGINE_CRUNNERUTILS_H_ #ifndef EXECUTIONENGINE_CRUNNERUTILS_H_
#define EXECUTIONENGINE_CRUNNERUTILS_H_ #define EXECUTIONENGINE_CRUNNERUTILS_H_
#ifdef _WIN32 #ifdef _WIN32
#ifndef MLIR_CRUNNERUTILS_EXPORT #ifndef MLIR_CRUNNERUTILS_EXPORT
#ifdef mlir_c_runner_utils_EXPORTS #ifdef mlir_c_runner_utils_EXPORTS
/* We are building this library */ /* We are building this library */
#define MLIR_CRUNNERUTILS_EXPORT __declspec(dllexport) #define MLIR_CRUNNERUTILS_EXPORT __declspec(dllexport)
#define MLIR_CRUNNERUTILS_DEFINE_FUNCTIONS
#else #else
/* We are using this library */ /* We are using this library */
#define MLIR_CRUNNERUTILS_EXPORT __declspec(dllimport) #define MLIR_CRUNNERUTILS_EXPORT __declspec(dllimport)
#endif // mlir_c_runner_utils_EXPORTS #endif // mlir_c_runner_utils_EXPORTS
#endif // MLIR_CRUNNERUTILS_EXPORT #endif // MLIR_CRUNNERUTILS_EXPORT
#else #else
#define MLIR_CRUNNERUTILS_EXPORT #define MLIR_CRUNNERUTILS_EXPORT
#define MLIR_CRUNNERUTILS_DEFINE_FUNCTIONS
#endif // _WIN32 #endif // _WIN32
#include <cstdint> #include <cstdint>
template <int N> template <int N>
void dropFront(int64_t arr[N], int64_t *res) { void dropFront(int64_t arr[N], int64_t *res) {
for (unsigned i = 1; i < N; ++i) for (unsigned i = 1; i < N; ++i)
*(res + i - 1) = arr[i]; *(res + i - 1) = arr[i];
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines

mlir/lib/ExecutionEngine/CRunnerUtils.cpp

Show All 11 Lines
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "mlir/ExecutionEngine/CRunnerUtils.h" #include "mlir/ExecutionEngine/CRunnerUtils.h"
#include <cinttypes> #include <cinttypes>
#include <cstdio> #include <cstdio>
#ifdef MLIR_CRUNNERUTILS_DEFINE_FUNCTIONS
// Small runtime support "lib" for vector.print lowering. // Small runtime support "lib" for vector.print lowering.
// By providing elementary printing methods only, this // By providing elementary printing methods only, this
// library can remain fully unaware of low-level implementation // library can remain fully unaware of low-level implementation
aartbikUnsubmitted
Done
ReplyInline Actions

some whitespace was introduced here by mistake

aartbik: some whitespace was introduced here by mistake
// details of our vectors. Also useful for direct LLVM IR output. // details of our vectors. Also useful for direct LLVM IR output.
extern "C" void print_i32(int32_t i) { fprintf(stdout, "%" PRId32, i); } extern "C" void print_i32(int32_t i) { fprintf(stdout, "%" PRId32, i); }
extern "C" void print_i64(int64_t l) { fprintf(stdout, "%" PRId64, l); } extern "C" void print_i64(int64_t l) { fprintf(stdout, "%" PRId64, l); }
extern "C" void print_f32(float f) { fprintf(stdout, "%g", f); } extern "C" void print_f32(float f) { fprintf(stdout, "%g", f); }
extern "C" void print_f64(double d) { fprintf(stdout, "%lg", d); } extern "C" void print_f64(double d) { fprintf(stdout, "%lg", d); }
extern "C" void print_open() { fputs("( ", stdout); } extern "C" void print_open() { fputs("( ", stdout); }
extern "C" void print_close() { fputs(" )", stdout); } extern "C" void print_close() { fputs(" )", stdout); }
extern "C" void print_comma() { fputs(", ", stdout); } extern "C" void print_comma() { fputs(", ", stdout); }
extern "C" void print_newline() { fputc('\n', stdout); } extern "C" void print_newline() { fputc('\n', stdout); }
#endif
aartbikUnsubmitted
Done
ReplyInline Actions

missing newline

aartbik: missing newline