Page MenuHomePhabricator

[VPlan] Do not print mapping for Value2VPValue.
ClosedPublic

Authored by fhahn on Mar 18 2020, 11:09 AM.

Details

Summary

The latest improvements to VPValue printing make this mapping clear when
printing the operand. Printing the mapping separately is not required
any longer.

Diff Detail

Event Timeline

fhahn created this revision.Mar 18 2020, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2020, 11:09 AM
Ayal accepted this revision.Mar 18 2020, 1:04 PM

Minor nit.
Thanks for following up quickly on https://reviews.llvm.org/D76200#inline-694794

llvm/lib/Transforms/Vectorize/VPlan.cpp
582–583

This second if is now redundant.

Once we can assign VPValues (meaningful) names, this should be removed as well.

This revision is now accepted and ready to land.Mar 18 2020, 1:04 PM
fhahn added a comment.Mar 18 2020, 2:44 PM

Thanks Ayal! I've committed the change with the redundant if removed.

This revision was automatically updated to reflect the committed changes.