Differential D76372

[mlir] Disable notifyMatchFailure in NDEBUG
ClosedPublic
Actions

Authored by rriddle on Mar 18 2020, 10:12 AM.

Details

Reviewers

Commits

rG64a5e57a61bb: [mlir] Disable notifyMatchFailure in NDEBUG

Summary

The usage story in for NDEBUG isn't fleshed out yet, so this revision ensures that none of the diagnostic code exists in the binary.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rriddle created this revision.Mar 18 2020, 10:12 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2020, 10:12 AM

Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 8 others. · View Herald Transcript

mehdi_amini accepted this revision.Mar 18 2020, 10:22 AM

This revision is now accepted and ready to land.Mar 18 2020, 10:22 AM

Harbormaster completed remote builds in B49620: Diff 251127.Mar 18 2020, 11:57 AM

Closed by commit rG64a5e57a61bb: [mlir] Disable notifyMatchFailure in NDEBUG (authored by rriddle). · Explain WhyMar 18 2020, 1:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

IR/

22 lines

Diff 251165

mlir/include/mlir/IR/PatternMatch.h

Loading...