This is an archive of the discontinued LLVM Phabricator instance.

Differential D76333

[MLIR] Allow global with external linkage to include an initial value
ClosedPublic

Authored by schweitz on Mar 17 2020, 4:20 PM.

Details

Reviewers
rriddle
ftynse
Commits
rG7b5d4669daa4: [MLIR] Allow global with an external linkage to include initial value
Summary

Currently, globals with external linkage always elide their initial values even when they are set.

Diff Detail

Event Timeline

schweitz created this revision.Mar 17 2020, 4:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2020, 4:20 PM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 9 others. · View Herald Transcript
Harbormaster completed remote builds in B49519: Diff 250940.Mar 17 2020, 5:19 PM
schweitz added a reviewer: ftynse.Mar 17 2020, 6:13 PM
ftynse accepted this revision.Mar 18 2020, 2:33 AM
This revision is now accepted and ready to land.Mar 18 2020, 2:33 AM
Closed by commit rG7b5d4669daa4: [MLIR] Allow global with an external linkage to include initial value (authored by schweitz). · Explain WhyMar 18 2020, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Target/
LLVMIR/
3 lines

Diff 251188

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

Show First 20 Lines • Show All 464 Lines • ▼ Show 20 Lines if (op.getValueOrNull()) {
return emitError(op.getLoc(), "unemittable constant value"); return emitError(op.getLoc(), "unemittable constant value");
} }
ReturnOp ret = cast<ReturnOp>(initializer->getTerminator()); ReturnOp ret = cast<ReturnOp>(initializer->getTerminator());
cst = cast<llvm::Constant>(valueMapping.lookup(ret.getOperand(0))); cst = cast<llvm::Constant>(valueMapping.lookup(ret.getOperand(0)));
} }
auto linkage = convertLinkageToLLVM(op.linkage()); auto linkage = convertLinkageToLLVM(op.linkage());
bool anyExternalLinkage = bool anyExternalLinkage =
(linkage == llvm::GlobalVariable::ExternalLinkage || ((linkage == llvm::GlobalVariable::ExternalLinkage &&
isa<llvm::UndefValue>(cst)) ||
linkage == llvm::GlobalVariable::ExternalWeakLinkage); linkage == llvm::GlobalVariable::ExternalWeakLinkage);
auto addrSpace = op.addr_space().getLimitedValue(); auto addrSpace = op.addr_space().getLimitedValue();
auto *var = new llvm::GlobalVariable( auto *var = new llvm::GlobalVariable(
*llvmModule, type, op.constant(), linkage, *llvmModule, type, op.constant(), linkage,
anyExternalLinkage ? nullptr : cst, op.sym_name(), anyExternalLinkage ? nullptr : cst, op.sym_name(),
/*InsertBefore=*/nullptr, llvm::GlobalValue::NotThreadLocal, addrSpace); /*InsertBefore=*/nullptr, llvm::GlobalValue::NotThreadLocal, addrSpace);
globalsMapping.try_emplace(op, var); globalsMapping.try_emplace(op, var);
▲ Show 20 Lines • Show All 192 Lines • Show Last 20 Lines