Page MenuHomePhabricator

[Alignment] Add alignTo with skew parameter
ClosedPublic

Authored by gchatelet on Mar 17 2020, 10:28 AM.

Details

Summary

This is derived from MathExtra's alignTo

Diff Detail

Event Timeline

gchatelet created this revision.Mar 17 2020, 10:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2020, 10:28 AM
gchatelet edited the summary of this revision. (Show Details)Mar 17 2020, 10:29 AM
gchatelet added a reviewer: courbet.
gchatelet edited the summary of this revision. (Show Details)Mar 17 2020, 10:31 AM
courbet accepted this revision.Mar 17 2020, 10:39 AM
courbet added inline comments.
llvm/include/llvm/Support/Alignment.h
192

Value

llvm/unittests/Support/AlignmentTest.cpp
129

Add a test for 0 ?

This revision is now accepted and ready to land.Mar 17 2020, 10:39 AM
gchatelet updated this revision to Diff 250754.Mar 17 2020, 1:47 PM
gchatelet marked 3 inline comments as done.

Address comments

llvm/include/llvm/Support/Alignment.h
192

Also fixed in the function above.

This revision was automatically updated to reflect the committed changes.