[Alignment] Add alignTo with skew parameter

[gchatelet]

Summary

This is derived from MathExtra's alignTo

[courbet]

llvm/include/llvm/Support/Alignment.h

192

Value

llvm/unittests/Support/AlignmentTest.cpp

129

Add a test for 0 ?

[gchatelet]

Address comments

llvm/include/llvm/Support/Alignment.h

192

Also fixed in the function above.

llvm/include/llvm/Support/Alignment.h

 
 /// Checks that Addr is a multiple of the alignment.
 inline bool isAddrAligned(Align Lhs, const void *Addr) {
   return isAligned(Lhs, reinterpret_cast<uintptr_t>(Addr));
 }
 
 /// Returns a multiple of A needed to store `Size` bytes.
 inline uint64_t alignTo(uint64_t Size, Align A) {
-  const uint64_t value = A.value();
-  // The following line is equivalent to `(Size + value - 1) / value * value`.
+  const uint64_t Value = A.value();
+  // The following line is equivalent to `(Size + Value - 1) / Value * Value`.
 
   // The division followed by a multiplication can be thought of as a right
   // shift followed by a left shift which zeros out the extra bits produced in
-  // the bump; `~(value - 1)` is a mask where all those bits being zeroed out
+  // the bump; `~(Value - 1)` is a mask where all those bits being zeroed out
   // are just zero.
 
   // Most compilers can generate this code but the pattern may be missed when
   // multiple functions gets inlined.
-  return (Size + value - 1) & ~(value - 1U);
+  return (Size + Value - 1) & ~(Value - 1U);
 }
 
 /// If non-zero \p Skew is specified, the return value will be a minimal integer
 /// that is greater than or equal to \p Size and equal to \p A * N + \p Skew for
 /// some integer N. If \p Skew is larger than \p A, its value is adjusted to '\p
 /// Skew mod \p A'.
 ///
 /// Examples:
 /// \code
 ///   alignTo(5, Align(8), 7) = 7
 ///   alignTo(17, Align(8), 1) = 17
 ///   alignTo(~0LL, Align(8), 3) = 3
 /// \endcode
 inline uint64_t alignTo(uint64_t Size, Align A, uint64_t Skew) {
-  const uint64_t value = A.value();
-  Skew %= value;
-  return ((Size + value - 1 - Skew) & ~(value - 1U)) + Skew;
+  const uint64_t Value = A.value();
+  Skew %= Value;
+  return ((Size + Value - 1 - Skew) & ~(Value - 1U)) + Skew;
 }
 
 /// Returns a multiple of A needed to store `Size` bytes.
 /// Returns `Size` if current alignment is undefined.
 inline uint64_t alignTo(uint64_t Size, MaybeAlign A) {
   return A ? alignTo(Size, A.getValue()) : Size;
 }
 

llvm/unittests/Support/AlignmentTest.cpp

for (const auto &T : kTests) {
     if (A) {
       EXPECT_EQ(alignTo(T.offset, A.getValue()), T.rounded);
       EXPECT_EQ(alignAddr(T.forgedAddr(), A.getValue()), T.rounded);
     }
   }
 }
 
 TEST(AlignmentTest, AlignToWithSkew) {
+  EXPECT_EQ(alignTo(5, Align(8), 0), alignTo(5, Align(8)));
   EXPECT_EQ(alignTo(5, Align(8), 7), 7U);
   EXPECT_EQ(alignTo(17, Align(8), 1), 17U);
   EXPECT_EQ(alignTo(~0LL, Align(8), 3), 3U);
 }
 
 TEST(AlignmentTest, Log2) {
   for (uint64_t Value : getValidAlignments()) {
     EXPECT_EQ(Log2(Align(Value)), Log2_64(Value));