Page MenuHomePhabricator

Make amdgpu- options ZeroOrMore
AbandonedPublic

Authored by yaxunl on Mar 12 2020, 8:40 AM.

Details

Reviewers
arsenm
rampitec
Summary

Currently all amdgpu- options can only occur once in command line, which makes them very
inconvenient to use since users cannot override them.

This patch make them ZeroOrMore, which allows them to be overridden.

Diff Detail

Event Timeline

yaxunl created this revision.Mar 12 2020, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2020, 8:40 AM

These aren't actually intended for user use

arsenm requested changes to this revision.Mar 12 2020, 8:49 AM

I don't think this should be done. These are for testing, and should always have a single, explicit setting. These are unstable, and users should not be trying to set or use these flags

This revision now requires changes to proceed.Mar 12 2020, 8:49 AM
yaxunl abandoned this revision.Mar 30 2020, 9:00 AM