This is an archive of the discontinued LLVM Phabricator instance.

Differential D75969

[clangd] Link libClangDaemonTweaks to libClangFormat
ClosedPublic

Authored by nridge on Mar 10 2020, 6:24 PM.

Details

Reviewers
None
Commits
rG48121a5743b6: [cmake] Link libclangDaemonTweaks with clangFormat
Summary

This fixes bustage from https://reviews.llvm.org/D75716.

Diff Detail

Event Timeline

nridge created this revision.Mar 10 2020, 6:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2020, 6:24 PM
Herald added subscribers: cfe-commits, usaxena95, kadircet and 5 others. · View Herald Transcript
hubert.reinterpretcast added a subscriber: hubert.reinterpretcast.Mar 10 2020, 6:35 PM

Thanks for the prompt response. It seems our fix attempts happened "concurrently" and we ended up with pretty much the same fix. I had committed rG48121a5743b684def33d158391c5424626de28e2 before seeing this.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2020, 6:37 PM
Closed by commit rG48121a5743b6: [cmake] Link libclangDaemonTweaks with clangFormat (authored by hubert.reinterpretcast). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B48768: Diff 249532.Mar 10 2020, 7:09 PM

Revision Contents

PathSize
clang-tools-extra/
clangd/
refactor/
tweaks/
1 line

Diff 249534

clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

Show All 23 Linesadd_clang_library(clangDaemonTweaks OBJECT
RawStringLiteral.cpp RawStringLiteral.cpp
RemoveUsingNamespace.cpp RemoveUsingNamespace.cpp
SwapIfBranches.cpp SwapIfBranches.cpp
LINK_LIBS LINK_LIBS
clangAST clangAST
clangBasic clangBasic
clangDaemon clangDaemon
clangFormat
clangLex clangLex
clangToolingCore clangToolingCore
clangToolingRefactoring clangToolingRefactoring
clangToolingSyntax clangToolingSyntax
) )